Uh oh!
There was an error while loading. Please reload this page.
Add CLOUDPICKLE_DEFAULT_PROTOCOL env to control the default pickle protocol - #265
Closed
HyukjinKwon wants to merge 1 commit into
Closed
Add CLOUDPICKLE_DEFAULT_PROTOCOL env to control the default pickle protocol#265HyukjinKwon wants to merge 1 commit into
HyukjinKwon wants to merge 1 commit into
Conversation
HyukjinKwonforce-pushed
the
env-default-protocol
branch
from
May 3, 2019 01:16
e944d94 to
faab38eCompareCodecov Report
@@ Coverage Diff @@## master #265 +/- ##
==========================================
+ Coverage 88.22% 88.24% +0.02%
==========================================
Files 1 1 Lines 552 553 +1 Branches 112 112 ==========================================
+ Hits 487 488 +1
Misses 42 42 Partials 23 23
Continue to review full report at Codecov.
|
HyukjinKwon
commented
May 4, 2019
MemberAuthor
Okie.Spark side worked round the bug and increased protocol back. Let me leave this closed. |
ogrisel
commented
May 15, 2019
Contributor
It's not a big overhead so let us know if you need to add it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to add an env
CLOUDPICKLE_DEFAULT_PROTOCOLfor users to set the default protocol.Few issues were found after Spark side upgrades cloudpickle from 0.4 to 0.8. Other issues were fixed but one issue is (I suspect) in Pyrolite or at least it's related. Spark uses Pyrolite to unpickle Python objects in JVM and looks Pyrolite has a bug when to unpickle lists (see SPARK-27612).
For clarification, I want this env as an internal purpose for now and see if this actually brings some overhead for dev. If it doesn't, I would like to keep this env. If it does, let's drop this env.