Skip to content

CLN cleanup stale code in when reducing a class - #271

Merged
ogrisel merged 1 commit into
cloudpipe:masterfrom
pierreglaser:dynamic-class-cleanup
May 21, 2019
Merged

CLN cleanup stale code in when reducing a class#271
ogrisel merged 1 commit into
cloudpipe:masterfrom
pierreglaser:dynamic-class-cleanup

Conversation

@pierreglaser

Copy link
Copy Markdown
Member

As a consequence of #262, I think some past workarounds used when saving dynamic classes can be removed. All tests seem to pass.

@codecov

codecovBot commented May 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #271 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #271 +/- ##
==========================================
- Coverage 89.35% 89.19% -0.16% 
==========================================
Files 1 1 Lines 620 611 -9 Branches 131 127 -4 ==========================================
- Hits 554 545 -9 
Misses 43 43 Partials 23 23
Impacted FilesCoverage Δ
cloudpickle/cloudpickle.py89.19% <ø> (-0.16%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce87fe4...40bda5d. Read the comment docs.

@ogrisel
ogrisel merged commit 3f4d9da into cloudpipe:masterMay 21, 2019
@ogrisel

Copy link
Copy Markdown
Contributor

Thanks very much @pierreglaser .

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pierreglaser@ogrisel