Skip to content

Dont pickle abc caches of instances of abc.ABCMeta subclasses. - #303

Merged
ogrisel merged 6 commits into
cloudpipe:masterfrom
pierreglaser:dont-pickle-abc-cache
Feb 10, 2020
Merged

Dont pickle abc caches of instances of abc.ABCMeta subclasses.#303
ogrisel merged 6 commits into
cloudpipe:masterfrom
pierreglaser:dont-pickle-abc-cache

Conversation

@pierreglaser

Copy link
Copy Markdown
Member

Closes#302

Don't pickle the abc caches populated during isinstance/issubclass checks against instances of abc.ABCMeta subclasses.

@pierreglaser

Copy link
Copy Markdown
MemberAuthor

@llllllllll if you want to take a look.

@pierreglaserpierreglaser changed the title Dont pickle abc cacheDont pickle abc caches of instances of abc.ABCMeta subclasses.Aug 1, 2019
@codecov

codecovBot commented Aug 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #303 into master will decrease coverage by 13.97%.
The diff coverage is 88.23%.

Impacted file tree graph

@@ Coverage Diff @@## master #303 +/- ##
===========================================
- Coverage 92.84% 78.86% -13.98% 
===========================================
Files 2 2 Lines 852 861 +9 Branches 177 178 +1 ===========================================
- Hits 791 679 -112 - Misses 37 143 +106 - Partials 24 39 +15
Impacted FilesCoverage Δ
cloudpickle/cloudpickle_fast.py94.84% <87.5%> (-0.31%)⬇️
cloudpickle/cloudpickle.py72.92% <88.88%> (-19.08%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0a0b1...746c5a2. Read the comment docs.

@codecov

codecovBot commented Aug 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #303 +/- ##
======================================
Coverage 92.9% 92.9% ======================================
Files 2 2 Lines 860 860 Branches 179 179 ======================================
Hits 799 799 Misses 37 37 Partials 24 24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cac138...d4743fb. Read the comment docs.

@ogriselogrisel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe @pitrou wants to have a look as I think he originally contributed the 3.7+ code.

@ogriselogrisel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the changelog need an update.

Comment threadCHANGES.md
@ogrisel
ogrisel merged commit c34333e into cloudpipe:masterFeb 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to loads a dumped MetaClass object

2 participants

@pierreglaser@ogrisel