Skip to content

Don't include base class __slots__ in subclass construction - #314

Merged
ogrisel merged 5 commits into
cloudpipe:masterfrom
pierreglaser:fix-inherited-slots
Feb 10, 2020
Merged

Don't include base class __slots__ in subclass construction#314
ogrisel merged 5 commits into
cloudpipe:masterfrom
pierreglaser:fix-inherited-slots

Conversation

@pierreglaser

Copy link
Copy Markdown
Member

Fixes#311

@codecov

codecovBot commented Oct 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #314 +/- ##
=======================================
Coverage 92.96% 92.96% =======================================
Files 2 2 Lines 853 853 Branches 178 178 =======================================
Hits 793 793 Misses 37 37 Partials 23 23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649fc59...8353372. Read the comment docs.

@pierreglaserpierreglaser changed the title TST add a test pickling class with inherited slotsDon't include base class __slots__ in subclass constructionOct 26, 2019

@ogriselogrisel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel
ogrisel merged commit 6e17ea9 into cloudpipe:masterFeb 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failed to pickle objects inherited from __slots__ in 1.2.2

2 participants

@pierreglaser@ogrisel