Uh oh!
There was an error while loading. Please reload this page.
test properties on a new-style class. - #332
Merged
pierreglaser merged 2 commits intoJan 29, 2020
Merged
Conversation
Properties only work on new-style classes
ogrisel
commented
Jan 29, 2020
Contributor
Could you please add a comment to explain this? |
ogrisel
commented
Jan 29, 2020
Contributor
BTW we should consider making a new major cloudpickle release that stop supporting Python 2 in the coming months :) |
ogrisel
approved these changes
Jan 29, 2020
ogrisel
left a comment
Contributor
There was a problem hiding this comment.
+1 for merge once the comment is added.
Codecov Report
@@ Coverage Diff @@## master #332 +/- ##
===========================================
+ Coverage 53.05% 65.49% +12.44%
===========================================
Files 2 2 Lines 852 855 +3 Branches 176 177 +1 ===========================================
+ Hits 452 560 +108 + Misses 365 269 -96 + Partials 35 26 -9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #329
Properties only work on new-style classes, that's why
test_propertyis failing onPython2tests.