Uh oh!
There was an error while loading. Please reload this page.
Compatibility: expose cloudpickle.CloudPickler also as cloudpickle.Pickler - #392
Conversation
Codecov Report
@@ Coverage Diff @@## master #392 +/- ##
=======================================
Coverage 91.61% 91.61% =======================================
Files 3 3 Lines 656 656 Branches 135 135 =======================================
Hits 601 601 Misses 34 34 Partials 21 21 Continue to review full report at Codecov.
|
pierreglaser
left a comment
There was a problem hiding this comment.
LGTM, Thanks @twoertwein. This also needs a changelog entry - can you write one?
Regarding the README, issue, I think that at some point we should make it clear that accessing cloudpickle.Pickler is now the recommended way to use cloudpickle's Pickler subclass. But it is not urgent, so I won't mind if we leave the README as it is for now.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Pierre Glaser <pierreglaser@msn.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pierreglaser
commented
Aug 13, 2020
Alright, let's merge! Thank you very much @twoertwein. |
I'll do a release of |
Some people/projects expect that a module implementing a Pickler, provides the Pickler class as
<module>.Pickler, for example pytorch/pytorch#38098.Since the current version of Cloudpickler doesn't define
cloudpickle.Pickler, let's definecloudpickle.Picklerascloudpickle.CloudPickler.Fixes#366