Skip to content

Run Dask's test_pickle_empty on CI again - #442

Merged
pierreglaser merged 3 commits into
cloudpipe:masterfrom
jakirkham:tst_empty_pickle_dask
Sep 10, 2021
Merged

Run Dask's test_pickle_empty on CI again#442
pierreglaser merged 3 commits into
cloudpipe:masterfrom
jakirkham:tst_empty_pickle_dask

Conversation

@jakirkham

Copy link
Copy Markdown
Member

We needed to skip this in PR ( #432 ) as it was failing. This has since been fixed upstream ( dask/distributed#5303 ). So readd testing of it.

@jakirkhamjakirkham mentioned this pull request Sep 10, 2021
@codecov

codecovBot commented Sep 10, 2021

Copy link
Copy Markdown

Codecov Report

Merging #442 (cc6c1a5) into master (ef6fb90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #442 +/- ##
=======================================
Coverage 92.36% 92.36% =======================================
Files 4 4 Lines 720 720 Branches 150 150 =======================================
Hits 665 665 Misses 34 34 Partials 21 21 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6fb90...cc6c1a5. Read the comment docs.

@pierreglaserpierreglaser added the ci distributed Signal the CI to run the test suite of distributed (downstream project of cloudpickle) label Sep 10, 2021

@pierreglaserpierreglaser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I've activated running distributed's test suite for this PR. Can you push an empty commit to trigger a new build?

@jakirkham

Copy link
Copy Markdown
MemberAuthor

Yep thanks Pierre 😄 Pushed an empty commit above

@jakirkham

Copy link
Copy Markdown
MemberAuthor

There was one more flaky test. Added that to skip list with a reference. Otherwise seems to be working 🙂

@pierreglaser
pierreglaser merged commit 9fdb09f into cloudpipe:masterSep 10, 2021
@pierreglaser

Copy link
Copy Markdown
Member

thank you very much @jakirkham for your support on the distributed-side of cloudpickle'CI!

@jakirkham
jakirkham deleted the tst_empty_pickle_dask branch September 10, 2021 17:17
@jakirkham

Copy link
Copy Markdown
MemberAuthor

Ofc thanks for your help as well, Pierre :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci distributedSignal the CI to run the test suite of distributed (downstream project of cloudpickle)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakirkham@pierreglaser