Uh oh!
There was an error while loading. Please reload this page.
add -edit-comment-regex flag to edit existing comments - #26
Merged
Conversation
Similar to -delete-comment-regex but edit existing comment(s) instead of deleting / recreating
Erik Osterman (Cloud Posse) (osterman)
requested a review
from Andriy Knysh (aknysh)April 10, 2021 00:33
Andriy Knysh (aknysh)
approved these changes
Apr 10, 2021
Andriy Knysh (aknysh)
left a comment
Member
There was a problem hiding this comment.
thanks joe miller (@joemiller)
This was referenced May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New flag
-edit-comment-regex. Similar to-delete-comment-regexbut edit existing comment(s) instead of deleting / recreating.If there are no matching comments a new comment is created so that the call is idempotent. Users can run the same command in a CI pipeline to create or update comments.
I updated the readme.yaml but did not commit a regenerated
README.md. There were too many differences (like missing badges) that I thought something might be wrong w/ my local setup.I updated the google/go-github lib to the latest
v34.0.0to fix what I thought was a bug but turned out not to be. The code should work fine onv17.0.0if that needs to be backed out.closes#24