Uh oh!
There was an error while loading. Please reload this page.
feat: Update to Arrow v18 - #445
Merged
Merged
Conversation
erezrokah
requested review from
a team and dcelasun
and removed request for
a teamDecember 6, 2024 18:03
5 tasks
marianogappa
approved these changes
Dec 13, 2024
kodiakhqBot
pushed a commit
that referenced
this pull request
Dec 13, 2024
🤖 I have created a release *beep* *boop* --- ## [1.26.0](v1.25.6...v1.26.0) (2024-12-13) ### Features * Update to Arrow v18 ([#445](#445)) ([2cccfa7](2cccfa7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhqBot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Dec 13, 2024
#### Summary Goes with cloudquery/plugin-pb-go#445 Interesting bit is https://arrow.apache.org/blog/2024/10/23/arrow-go-18.0.0-release/#canonical-extension-types that we might be able to drop our UUID and JSON own extension types, but probably better to do that separately Had to do 3ae4778 to get the tests working, followed apache/arrow#43679 as a reference ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/cloudquery/cloudquery-issues/issues/2806 (internal issue).
Since Arrow Go moved to a new repo, we won't get automatic updates until we migrate manually.
There's https://docs.renovatebot.com/configuration-options/#replacementname but it doesn't support
go.modUse the following steps to ensure your PR is ready to be reviewed
go fmt ./...to format your code 🖊golangci-lint run🚨 (install golangci-lint here)