[BUG] Audit and remove 104 silent .catch(() => {}) in production code

[moizlatif7]

Summary

The CLI production code silently swallows errors in 104 places using .catch(() => {}) (or equivalents like .catch(() => undefined), .catch((_) => {})). This is the single most likely explanation for user reports of vague "unreliability" — errors that would help diagnose problems are dropped without any log, telemetry, or user-visible message.

Reproduction / Measurement

grep -rn '\.catch(() => {})\|\.catch((_) => {})\|\.catch(() => undefined)\|\.catch(() => null)' \
 packages/opencode/src/ packages/anr-core/src/ packages/llm/src/ \
 | grep -v node_modules | grep -v test | wc -l
# → 104

Representative Examples

File:line	What's swallowed
packages/opencode/src/config/config.ts:274	Config-loading failure
packages/opencode/src/lsp/lsp.ts:362	LSP initialization failure
packages/opencode/src/lsp/server.ts:675	fs.chmod failure on LSP binary
packages/opencode/src/lsp/server.ts:1055	fs.chmod on clangd binary
packages/opencode/src/lsp/server.ts:1058	fs.unlink for symlink cleanup
packages/opencode/src/lsp/server.ts:1059	fs.symlink for clangd
packages/opencode/src/lsp/server.ts:1347	Launcher script chmod
packages/opencode/src/plugin/tui/runtime.ts:273	PluginMeta.setTheme failure
packages/opencode/src/plugin/tui/runtime.ts:302	Filesystem.write failure
packages/opencode/src/plugin/tui/runtime.ts:307	Plugin runtime setup
packages/opencode/src/plugin/tui/runtime.ts:680	Async wait
packages/opencode/src/plugin/xai.ts:606	xAI provider network
packages/opencode/src/plugin/digitalocean.ts:314	DigitalOcean provider
packages/opencode/src/plugin/snowflake-cortex.ts:338,375	Snowflake Cortex provider
packages/opencode/src/cli/upgrade.ts:52	Auto-update result emit

Policy — What Each Should Become

1. Truly ignorable (e.g., best-effort cleanup that legitimately can't fail loudly): replace with .catch((err) => log.debug({ msg: "ignored", err })) — never bare {}.
2. User action needed (config load, auth, provider init): re-throw or wrap in a typed error and surface to the TUI.
3. Diagnostic-only (telemetry, cache): keep silent but record via OTEL.

Acceptance Criteria

• Net count of bare .catch(() => {}) in prod code drops to ≤10, and each remaining occurrence has an inline comment explaining why silence is correct.
• All swallowed errors that indicate user-actionable problems (auth failure, config invalid, provider unreachable) become user-visible.
• A lint rule (Biome or oxlint) fires on new bare .catch(() => {}) unless justified.
• Regression tests: at least 3 scenarios where a previously-silent failure now surfaces to the caller.

Related

• Release Validation Pipeline: Close the Upstream-Sync Test Gap #307 (test-gap; this ticket is complementary — better error propagation makes tests more expressive)
• Prior ticket in this audit series (ModelsDev failures — the models cache path likely swallows write errors somewhere here)

Scope

In scope: packages/opencode/src/, packages/anr-core/src/, packages/llm/src/
Out of scope: test files, tools/scripts, and packages/core/src/ (already largely uses Effect's typed errors)

[moizlatif7]

Implementation complete. Draft PR opened: #355

Branch: anr/331/fix-silent-catch-handlers

• 104 bare .catch(() => {}) handlers replaced (0 remaining)
• 25 files modified with ANRCode markers
• 5 regression tests added
• Awaiting human review and merge.

[moizlatif7]

@copilot Link this ticket to PR #355