Uh oh!
There was an error while loading. Please reload this page.
chore: Remediate 3 Dependabot security alerts - #253
Merged
Conversation
Remove react-router-dom (^6.30.4) from devDependencies to remediate three open Dependabot security alerts: - GHSA-wrjc-x8rr-h8h6 (CVE-2026-53669): react-router open redirect - GHSA-jjmj-jmhj-qwj2 (CVE-2026-53668): react-router-dom open redirect/XSS - GHSA-337j-9hxr-rhxg (CVE-2026-53666): react-router constructor injection react-router-dom v7 (the first patched line) requires react >= 18, but this package pins react ^16.14.0, so an upgrade is not viable. The dependency is dropped instead, following the same approach taken in cloudscape-design/build-tools#74. test-pages/src/index.tsx used only BrowserRouter + Routes + Route + Link for navigating between three dev-harness pages. This is replaced with a ~30-line hand-rolled router using window.location.pathname, useState, and a popstate listener — no new dependencies. URL structure is preserved: /focus-visible.page and /use-resize-observer-test continue to resolve exactly as before, keeping integration tests green. Lockfile delta: -3 entries (react-router-dom@6.30.4, react-router@6.30.4, @remix-run/router@1.23.3). No entries added. No non-dev dependency versions changed, so NPMPM check scope is empty.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #253 +/- ##
=======================================
Coverage 98.10% 98.10% =======================================
Files 56 56 Lines 1793 1793 Branches 524 519 -5 =======================================
Hits 1759 1759 - Misses 33 34 +1 + Partials 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pan-kot
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
react-router-domfromdevDependenciesand replaces its usage intest-pages/src/index.tsxwith a minimal hand-rolled pathname router. This closes all 3 open Dependabot security alerts. There are no auto-generated Dependabot PRs for these alerts; this is the sole gap PR.Alerts addressed by this PR
All three alerts share the same root cause:
react-router-dom@6.30.4and its transitivereact-router@6.30.4.Direct alert links (verbatim from Dependabot alerts API):
Merging this PR clears all 3 gap alerts this PR covers.
Why not upgrade?
first_patched_version: nullfor the 6.x line — no patched 6.x version exists.react-router >= 7.18.0(different major line).react-router-dom@7requiresreact >= 18; this package pinsreact ^16.14.0, so a v7 upgrade forces a React major bump — same constraint resolved by removing the dep in build-tools#74.What changed
test-pages/src/index.tsxusedBrowserRouter + Routes + Route + Linkonly to navigate between three dev-harness pages. Replaced with a ~30-line hand-rolled router usinguseState(window.location.pathname)+window.history.pushState+popstatelistener. URL structure is unchanged; integration tests are unaffected.Lockfile delta
react-router-dom@6.30.4,react-router@6.30.4,@remix-run/router@1.23.3NPMPM status
All 3 removed packages had
dev: true. No non-dev dependency versions changed. NPMPM check scope is empty — reviewer gate will show GREEN.Testing
npm run test:unit— 54 suites, 507 tests, all passedtsc --noEmitontest-pages/tsconfig.json— 0 errors in the changed filenpm audit— react-router / react-router-dom gone from output