Uh oh!
There was an error while loading. Please reload this page.
fix: exitcode fix - #328
Merged
Merged
Conversation
cloudsmith-iduffy
approved these changes
Jul 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores correct exit-code propagation for the PyInstaller-frozen Cloudsmith CLI entry point, and tightens the packaging smoketest to prevent regressions. It also bumps the patch version and documents the fix in the changelog.
Changes:
- Ensure the PyInstaller entry point exits with the Click/AliasGroup return code via
sys.exit(main()). - Update the offline smoketest to assert
cloudsmith whoamiagainst an unreachable API exits nonzero (and capture the actual return code). - Bump version to
1.20.1and add a changelog entry describing the regression and fix.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packaging/smoketest.sh | Captures and asserts whoami’s nonzero exit code in offline/unreachable-API mode. |
| packaging/pyinstaller/entry.py | Wraps CLI main() in sys.exit(...) to propagate the returned exit status in frozen builds. |
| cloudsmith_cli/data/VERSION | Patch version bump to 1.20.1. |
| CHANGELOG.md | Documents the exit-code propagation fix for standalone binaries in 1.20.1. |
| .bumpversion.cfg | Updates current_version to 1.20.1 for release tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was added and later accidentally removed in merging commits. Re-adding.
Type of Change
Additional Notes