Skip to content

Add support for specifying variable types using named parameter types - #547

Open
ejholmes wants to merge 1 commit into
masterfrom
parameter-type-names
Open

Add support for specifying variable types using named parameter types#547
ejholmes wants to merge 1 commit into
masterfrom
parameter-type-names

Conversation

@ejholmes

@ejholmesejholmes commented Mar 1, 2018

Copy link
Copy Markdown
Contributor

Closes#546

This just makes it a little easier to use CFNType's, by just specifying the name of the type you want for the parameter. The following now works:

VARIABLES= {
"VpcId": {
"type": "AWS::EC2::VPC::Id"
} }

And it'll be automatically normalized to:

VARIABLES= {
"VpcId": {
"type": EC2VPCId
}
}

@ejholmes
ejholmes requested a review from phobologicMarch 1, 2018 07:35
@ejholmesejholmes added this to the 1.3 milestone Mar 1, 2018
phobologic
phobologic approved these changes Apr 8, 2018
View reviewed changes

@phobologicphobologic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - needs docs.

Comment threadstacker/blueprints/base.py
"""Looks for any variable definitions that are a "str", and assumes that
they're the name of a CloudFormation parameter type, in which case the type
is converted to a CFNType.

@phobologicphobologicApr 8, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs Args

@ejholmesejholmes removed this from the 1.3 milestone Apr 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phobologicphobologicphobologic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ejholmes@phobologic