Sync: merge upstream v1.0.7 (DSN format fix for IAM token) - #8
Merged
Merged
Conversation
…aracuel#18) IAM auth tokens contain URL-special characters (:, ?, &, =, /) which cause lib/pq to misparse the postgresql://user:pass@host/db?args URL format. The error was: dial tcp: lookup root:paidly-prd-internal...:5432: no such host because lib/pq treated the entire user:pass@... as the hostname. Fix: use lib/pq's keyword-value format (host= port= user= password= dbname=) which does not rely on URL parsing and handles arbitrary password characters safely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Syncs latest upstream commit:
pkg/postgres/postgres.go)After merge, create tag
v1.0.7onmasterto trigger the chart release workflow.