Skip to content

Release/1.15.1 - #191

Merged
lmarini merged 8 commits into
masterfrom
release/1.15.1
Mar 17, 2021
Merged

Release/1.15.1#191
lmarini merged 8 commits into
masterfrom
release/1.15.1

Conversation

@lmarini

Copy link
Copy Markdown
Member

1.15.1 - 2021-03-12

Fixed

  • Several views were throwing errors trying to access a None value in EventSinkService when a user was not logged in.
    Replaced get() with getOrElse().
  • Consolidated field names sent by the EventSinkService to maximize reuse.
  • Changed EventSinkService logging to debug to minimize chatter.
  • Don't automatically create eventsink queue and bind it to eventsink exchange. Let clients do that so that we don't
    have a queue for the eventsink filling up if there are no consumers.

lmariniand others added 4 commits March 11, 2021 09:56
in `EventSinkService` when a user was not logged in.
Replaced `get()` with `getOrElse()`.
)
* Match EventSinkService fields to spreadsheet
* Inject timestamp when sending event, turn down logging
# Conflicts:
#	CHANGELOG.md
#	app/services/EventSinkService.scala
…xchange.
Let clients do that so that we don't have a queue for the eventsink filling up if there are no consumers.
Comment threadapp/services/EventSinkService.scala
Comment threadapp/services/EventSinkService.scala Outdated

@max-zillamax-zilla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran and verified new category field for events, didn't encounter issues. Didn't catch anything in code.

@bodom0015bodom0015 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RabbitMQMessageService.submit(exchange: String, routing_key: String, message: JsValue, exchange_type: String = "topic") now accepts a routing_key that represents a queue that may not exist.

Comment threadapp/services/rabbitmq/RabbitMQMessageService.scala
Comment threadapp/services/EventSinkService.scala Outdated
lmariniand others added 2 commits March 15, 2021 09:42
Co-authored-by: Mike Lambert <lambert8@illinois.edu>
Co-authored-by: Mike Lambert <lambert8@illinois.edu>

@bodom0015bodom0015 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the issue noted below. If we're moving RabbitMQ to a hard requirement then please disregard, but I don't recall that being part of the discussion of these feature.

Comment threadapp/services/EventSinkService.scala Outdated
@lmarini
lmarini merged commit 7d03641 into masterMar 17, 2021
@robkooper
robkooper deleted the release/1.15.1 branch October 1, 2021 23:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lmarini@bodom0015@robkooper@max-zilla