Skip to content

adding creator to space json returned, adding route for users in space - #453

Open
tcnichol wants to merge 5 commits into
developfrom
452-add-creator-to-json-returned-by-space-api-endpoints
Open

adding creator to space json returned, adding route for users in space#453
tcnichol wants to merge 5 commits into
developfrom
452-add-creator-to-json-returned-by-space-api-endpoints

Conversation

@tcnichol

@tcnicholtcnichol commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

Currently the space json does not include the creator for the api routes. I have added it since this will be needed for migrating spaces.

@tcnicholtcnichol linked an issue Aug 23, 2024 that may be closed by this pull request
add creator to json returned by space api endpoints #452
Open
@tcnichol
tcnichol marked this pull request as draft August 23, 2024 19:48
@tcnicholtcnichol changed the title adding creator to the space json returnedadding creator to space json returned, adding route for users in spaceAug 23, 2024
@tcnichol
tcnichol marked this pull request as ready for review August 23, 2024 20:11
@tcnicholtcnichol mentioned this pull request Aug 26, 2024
Open
6 tasks
longshuicy
longshuicy requested changes Aug 27, 2024
View reviewed changes

@longshuicylongshuicy left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I haven't got time to test it.
One thing I noticed, you probably also need to add an entry on Changelog.

Comment threadapp/api/Spaces.scala
Comment threadapp/api/Spaces.scala
This was referenced Sep 8, 2025
Open
Open
@tcnichol

tcnichol commented Sep 10, 2025

Copy link
Copy Markdown
ContributorAuthor

I added an entry to changelog, hoping to get this merged and a new release soon so we can work on migration

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longshuicylongshuicylongshuicy requested changes
@lmarinilmariniAwaiting requested review from lmarini
@max-zillamax-zillaAwaiting requested review from max-zilla
@robkooperrobkooperAwaiting requested review from robkooper

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add creator to json returned by space api endpoints

3 participants

@tcnichol@longshuicy@lmarini