Skip to content

Use reactphp/async instead of clue/reactphp-block - #83

Merged
clue merged 1 commit into
clue:mainfrom
clue-labs:async
Jan 24, 2026
Merged

Use reactphp/async instead of clue/reactphp-block#83
clue merged 1 commit into
clue:mainfrom
clue-labs:async

Conversation

@clue

@clueclue commented Jan 24, 2026

Copy link
Copy Markdown
Owner

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the test suite from using the deprecated clue/reactphp-block library to the modern reactphp/async library. The migration simplifies blocking operations in tests by using fibers-based async/await instead of the old blocking wait mechanism.

Changes:

  • Replaced clue/block-react dependency with reactphp/async in composer.json
  • Updated FunctionalTest.php to use React\Async\await() instead of Block\await()
  • Updated README.md documentation to reference reactphp/async instead of clue/reactphp-block

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

FileDescription
composer.jsonReplaced clue/block-react with react/async in dev dependencies
tests/FunctionalTest.phpMigrated from Block\await to React\Async\await, removed loop initialization, updated imports
README.mdUpdated blocking code example to use reactphp/async instead of clue/reactphp-block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadtests/FunctionalTest.php
Comment threadtests/FunctionalTest.php Outdated
Comment threadtests/FunctionalTest.php
Comment threadtests/FunctionalTest.php

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadtests/FunctionalTest.php
Comment threadtests/FunctionalTest.php
Comment threadtests/FunctionalTest.php
@clue
clue merged commit d7e653e into clue:mainJan 24, 2026
13 checks passed
@clue
clue deleted the async branch January 24, 2026 18:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue