Skip to content

Update README to reactphp/http v1.0.0 and add improved HTTP examples - #35

Merged
clue merged 3 commits into
clue:masterfrom
SimonFrings:readme
Oct 10, 2020
Merged

Update README to reactphp/http v1.0.0 and add improved HTTP examples#35
clue merged 3 commits into
clue:masterfrom
SimonFrings:readme

Conversation

@SimonFrings

@SimonFringsSimonFrings commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@SimonFringsSimonFrings changed the title Referencing reactphp/http instead of clue/reactphp-buzz in READMEUpdate README to reactphp/http v1.0.0 and add improved HTTP examplesAug 4, 2020
clue
clue requested changes Aug 6, 2020
View reviewed changes

@clueclue left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, add some minor remarks below :shipit:

Comment threadexamples/01-http-request.php Outdated
Comment threadREADME.md Outdated
Comment threadexamples/11-proxy-raw-https-protocol.php Outdated
Comment threadexamples/12-optional-proxy-raw-https-protocol.php Outdated
@clueclue added this to the v1.6.0 milestone Aug 6, 2020
@SimonFrings
SimonFrings requested a review from clueAugust 31, 2020 12:46
@SimonFrings
SimonFringsforce-pushed the readme branch 2 times, most recently from be89028 to 0703ddaCompareSeptember 8, 2020 10:20
clue
clue approved these changes Oct 10, 2020
View reviewed changes

@clueclue left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue
clue merged commit aaf8094 into clue:masterOct 10, 2020
@SimonFringsSimonFrings mentioned this pull request Oct 23, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clueclueclue approved these changes
+1 more reviewer
@Degra1991Degra1991Degra1991 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonFrings@clue@Degra1991