Skip to content

Fix typo in CHANGELOG.md - #53

Merged
clue merged 1 commit into
clue:1.xfrom
yadaiio:typo
Nov 23, 2023
Merged

Fix typo in CHANGELOG.md#53
clue merged 1 commit into
clue:1.xfrom
yadaiio:typo

Conversation

@yadaiio

@yadaiioyadaiio commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

This pull request fixes a typo with the help of https://github.com/szepeviktor/typos-on-you.

Builds on top of #43, #39, #37, #21 and #19.

@SimonFringsSimonFrings left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 👍

Seems like the test runs for legacy HHVM won't run, seems like we have to update our test suite as I did in clue/reactphp-csv#33.

Is this something you can look into?

@SimonFringsSimonFrings added the documentation Improvements or additions to documentation label Nov 14, 2023
@SimonFringsSimonFrings added this to the v1.9.0 milestone Nov 14, 2023

@clueclue left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue
clue merged commit 6e9475c into clue:1.xNov 23, 2023
@yadaiioyadaiio mentioned this pull request Feb 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yadaiio@clue@SimonFrings