Skip to content

Update test suite to ensure 100% code coverage - #68

Merged
clue merged 1 commit into
clue:1.xfrom
clue-labs:coverage
Apr 13, 2026
Merged

Update test suite to ensure 100% code coverage#68
clue merged 1 commit into
clue:1.xfrom
clue-labs:coverage

Conversation

@clue

@clueclue commented Apr 13, 2026

Copy link
Copy Markdown
Owner

This changeset updates the CI setup to ensure 100% code coverage.

Builds on top of #67 and clue/reactphp-eventsource#35

@clueclue added this to the v1.10.0 milestone Apr 13, 2026
@clue
clue requested a review from CopilotApril 13, 2026 00:09

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI pipeline and documentation to enforce and advertise 100% statement coverage for this library across the PHP test matrix.

Changes:

  • Generates Clover coverage output in CI and adds a step to fail the job unless coverage is 100%.
  • Adds @codeCoverageIgnore annotations to exclude a couple of hard-to-cover statements from coverage metrics.
  • Updates README with a 100% coverage badge and local coverage-report instructions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
src/ProxyConnector.phpAdds @codeCoverageIgnore markers to exclude specific statements from coverage.
README.mdDocuments 100% coverage goal and adds a static 100% coverage badge plus local coverage command.
.github/workflows/ci.ymlProduces clover.xml and enforces 100% statement coverage via a PHP check step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread.github/workflows/ci.yml
Comment threadsrc/ProxyConnector.php
@clue
clue merged commit 1206ad0 into clue:1.xApr 13, 2026
20 checks passed
@clue
clue deleted the coverage branch April 13, 2026 00:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue