Run tests on PHP 8.3 and update test suite - #19
Merged
Conversation
SimonFrings
suggested changes
Jan 22, 2024
SimonFrings
left a comment
Contributor
There was a problem hiding this comment.
@yadaiio Thanks for filing this PR, can you also adjust the composer.json similar to how you did in clue/reactphp-multicast?
yadaiio
commented
Jan 22, 2024
ContributorAuthor
Thank you @SimonFrings for noticing this. Should be fixed now 😉 |
SimonFrings
approved these changes
Jan 22, 2024
SimonFrings
left a comment
Contributor
There was a problem hiding this comment.
Thanks for changes, looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request builds on top of #11.
References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.