Use default php binary instead of respecting PHP_BINARY when automatic binary detection fails for non-CLI SAPIs - #50
Merged
Conversation
SimonFrings
approved these changes
Nov 12, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset ensures we use the default
phpbinary instead of respectingPHP_BINARYwhen automatic binary detection fails for non-CLI SAPIs. This ensure we never try to execute aphp-cgibinary when running behind CGI when the executable uses a custom name oropen_basedirrestrictions are in effect.The implementation is pretty straight forward, but significant effort went into making sure this works across the variety of supported platforms and is tested appropriately. You're looking at close to two days worth of testing alone, enjoy!
Builds on top of #48 and #45
Builds on top of #7
Refs #35