[WIP] Use socket pipes on Windows with PHP 8+ - #57
Closed
clue wants to merge 1 commit into
Closed
Conversation
clue
commented
Jan 11, 2022
OwnerAuthor
Closing this as the child process can not set STDIN/STDOUT to non-blocking mode on Windows even when the parent uses a socket in place of a normal pipe. Windows does already work without this change and this was filed in the hope to use a more consistent behavior on Windows, but it looks like we need to keep the current logic in place also looking forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #55 and #13