Update close handler to avoid unhandled promise rejections - #71
Merged
Conversation
clueforce-pushed
the
unhandled-rejections
branch
from
January 1, 2025 18:39
6070b21 to
1cd706eCompareclueforce-pushed
the
unhandled-rejections
branch
from
January 1, 2025 18:42
1cd706e to
c15c700CompareOwnerAuthor
Fixed unrelated build error by updating test environment to disable JIT due to Xdebug conflict (refs #64): https://github.com/shivammathur/setup-php#jit-configuration & https://xdebug.org/docs/compat#compat |
This was referenced Jan 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of reactphp/promise#248 and #63