Run tests on PHPUnit 9 and clean up test suite - #19
Merged
Conversation
clue
reviewed
Jul 29, 2020
| } | ||
| } | ||
| } | ||
| else { |
| } | ||
| else { | ||
| foreach ($fds as $i => $fd) { | ||
| $fds[$i] = (Int) $fd; |
Owner
There was a problem hiding this comment.
nit: CS
Changes LGTM otherwise, perhaps adjust return type to int[] accordingly?
SimonFringsforce-pushed
the
tests
branch
5 times, most recently
from
July 30, 2020 11:06
051ba38 to
297f2faCompareclue
approved these changes
Jul 30, 2020
clue
left a comment
Owner
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.