Skip to content

Update test environment to make tests pass again - #42

Merged
clue merged 1 commit into
clue:1.xfrom
clue-labs:update-tests
May 27, 2026
Merged

Update test environment to make tests pass again#42
clue merged 1 commit into
clue:1.xfrom
clue-labs:update-tests

Conversation

@clue

@clueclue commented May 27, 2026

Copy link
Copy Markdown
Owner

Builds on top of #39, #22, reactphp/socket#305 and others
Supersedes parts of #41/#40

@clueclue added this to the v1.5.0 milestone May 27, 2026
@clue
clue requested a review from CopilotMay 27, 2026 08:41

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s test tooling and CI configuration so the PHPUnit test suite can run reliably again across supported runtimes (including legacy PHP and HHVM), aligning configuration with newer PHPUnit and workflow environments.

Changes:

  • Update PHPUnit config schema references (legacy + modern) and align composer dev requirement to PHPUnit ^9.6.
  • Add react/promise-timer as a dev dependency to support timer helpers used in tests.
  • Refresh CI workflow environment (Ubuntu version, checkout action) and adjust HHVM execution to run via Docker.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

FileDescription
phpunit.xml.legacyGeneralizes legacy PHPUnit config comment wording.
phpunit.xml.distUpdates modern PHPUnit schema reference to 9.6.
composer.jsonBumps PHPUnit dev constraint, adds react/promise-timer, and reformats autoload blocks.
.github/workflows/ci.ymlMoves CI to Ubuntu 24.04, adjusts PHP matrix, updates checkout action, and reworks HHVM steps to use Docker.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread.github/workflows/ci.yml
@clue
clue merged commit c9f250b into clue:1.xMay 27, 2026
12 checks passed
@clue
clue deleted the update-tests branch May 27, 2026 08:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue