Skip to content

Full support for PHP 8.1: Update preg_split() default $limit argument - #101

Merged
clue merged 2 commits into
clue:mainfrom
cdosoftei:main
Jan 26, 2022
Merged

Full support for PHP 8.1: Update preg_split() default $limit argument#101
clue merged 2 commits into
clue:mainfrom
cdosoftei:main

Conversation

@cdosoftei

Copy link
Copy Markdown
Contributor

This pull request addresses a deprecation concerning the $limit argument passed to preg_split():

Deprecated: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in ./stdio-react/src/Readline.php on line 941

The adjustment should be compatible with the entire PHP version range supported by this library (>= 5.3).

@SimonFrings

Copy link
Copy Markdown
Contributor

@cdosoftei Thanks for looking into this one 👍

I guess you tested this with the PHP 8.1 version? If so, could you add 8.1 to the test matrix inside the .github\workflows\ci.yml. You also need to add convertDeprecationsToExceptions="true" to the phpunit.xml.dist then. For refs look into clue/ssh-proxy#32.

@cdosoftei

Copy link
Copy Markdown
ContributorAuthor

Thanks for the feedback @SimonFrings!

The requested updates are in.

@SimonFrings
SimonFrings requested a review from clueJanuary 26, 2022 11:37
@clueclue added the new feature New feature or request label Jan 26, 2022
@clueclue added this to the v2.6.0 milestone Jan 26, 2022
@clueclue changed the title Update preg_split() default $limit argumentFull support for PHP 8.1: Update preg_split() default $limit argumentJan 26, 2022

@clueclue left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdosoftei Thanks for looking into this, changes LGTM! :shipit: Keep it up!

@clue
clue merged commit 82d80ee into clue:mainJan 26, 2022
@spaceemotion

Copy link
Copy Markdown

I just stumbled upon this error and saw that it has been fixed already. Any idea when v2.6 comes out? I can't seem to force composer to install dev-main of this package instead...

@SimonFrings

Copy link
Copy Markdown
Contributor

Hey @spaceemotion, this will come out in the next couple of days, it's already on our ToDo list 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new featureNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cdosoftei@SimonFrings@spaceemotion@clue