Forward compatebility with ReactPHP packages - #51
Conversation
WyriHaximus
commented
Oct 26, 2017
I've contacted Travis about the missing build. Will comment here once that has been resolved. |
9fdd946 to
eca3e3bCompareWyriHaximus
commented
Oct 26, 2017
Issues resolved for Travis 🎉 |
Failing job is due to travis error with PHP 5.3 |
clue
commented
Oct 27, 2017
Thank you for filing this PR, much appreciated! I think your suggested changes make perfect sense and now that the (Also thanks for looking into the tests, I'll make sure to take care of the legacy PHP tests) |
clue
commented
Oct 27, 2017
Unrelated legacy PHP build error has been addressed via #52 |
WyriHaximus
commented
Oct 28, 2017
Updated the PR to use streams directly instead of wrapping them in |
… async-STDOUT # Conflicts: # src/Stdin.php # src/Stdio.php # src/Stdout.php
mpociot
commented
Dec 30, 2017
@clue any chance of getting this merged? |
clue
commented
Dec 30, 2017
@mpociot Thanks for the friendly ping :) It's near the top of my current TODOs, expect to see a result some time next week 👍 |
mpociot
commented
Dec 30, 2017
That’s great, thank you! |
marktopper
commented
Jan 18, 2018
@clue, any status on this? |
clue
commented
Jan 19, 2018
@marktopper, @WyriHaximus did a very good job at updating dependencies with this PR, but this has been superseded by changes on the |
WyriHaximus
commented
Jan 20, 2018
Cool so closing this in that case 👍 🎉 |
🎉