Skip to content

VSCode: bound the mailbox escalation-toast seen Set (dedupe by mailboxId with eviction) #1472

Description

@mohidmakhdoomi

What

The VSCode mailbox escalation toast (apps/vscode/src/notifications/mailbox-escalation-toast.ts, Spec 1313 Phase 8) dedupes "already shown" escalations with a seen Set that only ever grows — entries are added on show and never evicted. Over a long-lived extension host it accumulates one entry per escalated mailbox row for the lifetime of the window.

Bound it: dedupe by mailboxId with eviction (e.g. drop an id once its row leaves the escalated set, or cap the Set with LRU eviction).

Why

It's an unbounded-growth leak. Negligible in practice today — escalations are rare and each entry is tiny — but it's real, it was flagged as a non-blocking note in the Phase 8 round-2 CMAP, and an unbounded Set over an all-day extension host is the kind of thing that should just be bounded rather than reasoned about.

Notes

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/vscodeArea: VS Code extension

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions