Skip to content

streamdeck: rule the remaining working phases in or out of diff review mode (MAINTAIN maintain, EXPERIMENT execute/analyze, SPIKE spike) #1609

Description

@amrmelsayed

Context

#1606 / PR #1607 fixed the review dials' dead zones for BUGFIX (investigate/fix) and the BUGFIX+AIR pr phase via a registered DIFF_REVIEW_PHASES set in apps/streamdeck/src/actions.ts, plus an honest No review target strip label for unregistered phases. The 3-way review (Claude COMMENT) flagged the remaining unregistered working phases as an architect decision, deliberately left out of #1606's scope:

  • MAINTAINmaintain
  • EXPERIMENTexecute, analyze
  • SPIKEspike

Builders in these phases DO produce worktree diffs, but their review dials resolve to mode none: honestly inert now (the strip says No review target, no more lying label), yet inert.

Decision needed

Register these phase ids in DIFF_REVIEW_PHASES (dials drive the diff, matching the #1606 owner ruling's spirit that a working phase with a diff is diffable) — or rule them intentionally inert (e.g. if reviewing an experiment's scratch diff via dials has no value). Per-id decision; the registration note in actions.ts documents the mechanism.

Notes

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/streamdeckStream Deck plugin — apps/streamdeck, Elgato channel (profiles, Maker Console, packaging)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions