Uh oh!
There was an error while loading. Please reload this page.
Fix #759: pr-search includes all PR states so merged PRs are found - #1619
Merged
Conversation
… found gh pr list / glab mr list default to open-only; post-merge consult --type pr lookups returned nothing. Add --state all (github) / --all (gitlab), mirroring the pr-exists precedent (#568).
Uh oh!
There was an error while loading. Please reload this page.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean re-cut of #1331, which was accidentally branched from the Spec 1280 builder branch instead of main and therefore carried ~8.5k lines of unrelated churn around a 60-line fix. Same two commits (fix + regression test), cherry-picked onto current main; nothing else.
Problem
After a PR merges, the post-merge
consult --type prlookup fails withNo PR found for branch: …— the same lookup worked pre-merge. One of the roots of the "consult cannot review merged PRs" blocker (#1531).Root cause
The forge
pr-searchscripts callgh pr list --search …/glab mr list --search …with no state flag; both CLIs default to open-only, so merged PRs vanish from the search.Fix
--state all(GitHub) and--all(GitLab) in the twopr-search.shscripts, each with a comment citing #759.Testing
bugfix-759-pr-search-state-all.test.ts: both scripts fetch all states; both still pass the search query through. 3 files, +60/−2.Fixes#759. Supersedes #1331.
🤖 Generated with Claude Code