Uh oh!
There was an error while loading. Please reload this page.
chore: manage shared workspace deps through the pnpm catalog - #7
Open
fengmk2 wants to merge 1 commit into
Open
Conversation
Move every dependency declared by two or more workspace manifests into the pnpm-workspace.yaml catalog and reference it with catalog:, joining the vite/vite-plus/vitest entries vp migrate created. Single-package deps stay where they are. Resolutions are unchanged except the intended dedupe: apps/api's exact @types/react 19.2.2 / @types/react-dom 19.2.3 pins collapse onto the 19.2.17 / 19.2.4 versions apps/web already resolved, so the workspace now type-checks against one copy of the react types.
fengmk2
marked this pull request as ready for review
August 5, 2026 08:44
thonatos
approved these changes
Aug 5, 2026
thonatos
left a comment
Member
There was a problem hiding this comment.
Review 结论：LGTM（approve）
审查基准：populate-message-topic-author(base) → catalog-workspace-deps(head)，仅包含本提交。
已验证
- Lockfile 一致：本地
pnpm install --lockfile-only --frozen-lockfile通过；CI--frozen-lockfile+ 完整pnpm verify双跑均 SUCCESS，lockfile 净减 318 行。 - 去重符合预期：消除
@types/react@19.2.2、@types/react-dom@19.2.3、@types/node@22.20.1(+undici-types@6.21.0) 三套重复类型包。 - 其余版本解析逐一比对无变化。
非阻塞建议
apps/api的react/react-dom约束从精确19.2.8放宽为catalog: ^19.1.0：当前解析仍为 19.2.8，行为不变；但作为 API 生产依赖，后续pnpm update可能漂移。如需保持钉死，可考虑 catalog 内单独用精确值。这是本 PR 唯一真正的语义变化。- PR body 为空模板：建议勾选
No OpenSpec change needed并补充验证说明，方便合入记录。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenSpec
<!-- change name -->Verification
pnpm verifypassed.<!-- commands -->because<!-- reason -->.Impact Checklist
apps/,packages/)apps/api/src/routes/*.tszod-openapi declarations,api/openapi.jsonviapnpm gen:openapi)packages/db)deployment/)README.md,docs/,wiki/).github/workflows/,scripts/,package.json).env, tokens, cookies, private keys, database URLs, or user data committed.Migration / Deployment Notes