Uh oh!
There was an error while loading. Please reload this page.
Add multi-cause unwrap into Sentry reporting - #119
Merged
dhartunian merged 1 commit intoAug 23, 2023
Conversation
dhartunianforce-pushed
the
multierror-sentry
branch
from
August 22, 2023 13:06
4ee06e6 to
0d92d46Compareknz
reviewed
Aug 22, 2023
knz
left a comment
Contributor
There was a problem hiding this comment.
This LGTM after the 1st commit is finalized.
Reviewed 11 of 11 files at r2, all commit messages.
Reviewable status: 11 of 18 files reviewed, all discussions resolved
This commit modifies the causal detail collection code in `report.go` to recurse through both the single-cause chain and the multi-cause chain if applicable when collecting information for the Sentry report.
dhartunianforce-pushed
the
multierror-sentry
branch
from
August 23, 2023 15:16
0d92d46 to
f4eaeb8Comparedhartunian
commented
Aug 23, 2023
ContributorAuthor
@knz updated. |
knz
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies the causal detail collection code in
report.goto recurse through both the single-cause chain and the multi-cause
chain if applicable when collecting information for the Sentry report.
Please only review the last commit. Earlier ones are in #115 and #118.
This change is