Skip to content

Make multi-cause error support compatible with go versions before 1.20 - #122

Closed
dhartunian wants to merge 1 commit into
cockroachdb:go-1.18-compatfrom
dhartunian:go-1.18-compat
Closed

Make multi-cause error support compatible with go versions before 1.20#122
dhartunian wants to merge 1 commit into
cockroachdb:go-1.18-compatfrom
dhartunian:go-1.18-compat

Conversation

@dhartunian

@dhartuniandhartunian commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

This commit also reverts go.mod to use 1.18 to match the state of the
codebase from before the go 1.20 upgrade.

This allows older codebases to upgrade to a version of this library
that can encode/decode multi-cause errors from newer versions without
completely discarding the child cause error info.


This change is Reviewable

@dhartunian
dhartunian changed the base branch from master to go-1.18-compatAugust 24, 2023 20:14
@dhartuniandhartunian changed the title [WIP] Go 1.18 compatMake multi-cause changes compatible with go versions before 1.20Aug 24, 2023
@dhartuniandhartunian changed the title Make multi-cause changes compatible with go versions before 1.20Make multi-cause error support compatible with go versions before 1.20Aug 24, 2023
This commit also reverts go.mod to use 1.18 to match the state of the
codebase from before the go 1.20 upgrade.
This allows older codebases to upgrade to a version of this library
that can encode/decode multi-cause errors from newer versions without
completely discarding the child cause error info.
@dhartunian

Copy link
Copy Markdown
ContributorAuthor

Closing since I made a mistake. We need to revert to go 1.17, not 1.18

@dhartunian
dhartunian deleted the go-1.18-compat branch August 24, 2023 20:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dhartunian