Skip to content

build: min supported version is go 1.23#152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhartunian merged 2 commits into from
May 2, 2025
Merged

build: min supported version is go 1.23 #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
766aa4d
build: min supported version is go 1.23
dhartunian May 2, 2025
3a6e335
Merge branch 'master' into davidh/push-nzwovrxnkxmz
dhartunian May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,8 @@ jobs:
strategy:
matrix:
go:
- "1.18"
- "1.19"
- "1.20"
- "1.23"
- "1.24"
steps:
- uses: actions/checkout@v3

Expand All@@ -30,8 +29,8 @@ jobs:
strategy:
matrix:
go:
- "1.20"
- "1.21"
- "1.23"
- "1.24"
steps:
- uses: actions/checkout@v3

Expand Down
40 changes: 20 additions & 20 deletions fmttests/testdata/format/leaves
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ assertmsg oneline
(1) assertion failure
Wraps: (2) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func17
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -80,7 +80,7 @@ assertmsg ‹oneline›
(1) assertion failure
Wraps: (2) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func17
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -115,7 +115,7 @@ Error types: (1) *assert.withAssertionFailure (2) *withstack.withStack (3) *erru
(1) assertion failure
Wraps: (2) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func17
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -176,7 +176,7 @@ Title: "*errutil.leafError: assertmsg ×\nvia *withstack.withStack"
<path>:<lineno>:
(github.com/cockroachdb/errors/fmttests.TestDatadriven.func2) 1()
<path>:<lineno>:
(github.com/cockroachdb/errors/fmttests.glob.)...funcNN...
(github.com/cockroachdb/errors/fmttests.init)...funcNN...

run
ctx-canceled oneline twoline
Expand DownExpand Up@@ -659,7 +659,7 @@ twoline
new-style oneline
(1) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func16
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -706,7 +706,7 @@ new-style ‹oneline›
new-style ‹oneline›
(1) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func16
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -740,7 +740,7 @@ Error types: (1) *withstack.withStack (2) *errutil.leafError
<path>:<lineno>: new-style ×
(1) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func16
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -799,7 +799,7 @@ Title: "*errutil.leafError: new-style ×\nvia *withstack.withStack"
<path>:<lineno>:
(github.com/cockroachdb/errors/fmttests.TestDatadriven.func2) 1()
<path>:<lineno>:
(github.com/cockroachdb/errors/fmttests.glob.)...funcNN...
(github.com/cockroachdb/errors/fmttests.init)...funcNN...

run
newf-attached oneline twoline
Expand DownExpand Up@@ -842,7 +842,7 @@ twoline: payload
new-style oneline
(1) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func18
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -870,7 +870,7 @@ Wraps: (2) secondary error attachment
| payload
| (1) attached stack trace
| -- stack trace:
| | github.com/cockroachdb/errors/fmttests.glob...funcNN...
| | github.com/cockroachdb/errors/fmttests.init.func18
| | <tab><path>:<lineno>
| | github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| | <tab><path>:<lineno>
Expand DownExpand Up@@ -919,7 +919,7 @@ new-style ‹oneline›
new-style ‹oneline›
(1) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func18
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -947,7 +947,7 @@ Wraps: (2) secondary error attachment
| payload
| (1) attached stack trace
| -- stack trace:
| | github.com/cockroachdb/errors/fmttests.glob...funcNN...
| | github.com/cockroachdb/errors/fmttests.init.func18
| | <tab><path>:<lineno>
| | github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| | <tab><path>:<lineno>
Expand DownExpand Up@@ -983,7 +983,7 @@ Error types: (1) *withstack.withStack (2) *secondary.withSecondaryError (3) *err
<path>:<lineno>: new-style ×
(1) attached stack trace
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func18
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -1011,7 +1011,7 @@ Wraps: (2) secondary error attachment
| payload
| (1) attached stack trace
| -- stack trace:
| | github.com/cockroachdb/errors/fmttests.glob...funcNN...
| | github.com/cockroachdb/errors/fmttests.init.func18
| | <tab><path>:<lineno>
| | github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| | <tab><path>:<lineno>
Expand DownExpand Up@@ -1074,7 +1074,7 @@ Title: "*errutil.leafError: new-style ×\nvia *withstack.withStack"
<path>:<lineno>:
(github.com/cockroachdb/errors/fmttests.TestDatadriven.func2) 1()
<path>:<lineno>:
(github.com/cockroachdb/errors/fmttests.glob.)...funcNN...
(github.com/cockroachdb/errors/fmttests.init)...funcNN...

run
nofmt oneline twoline
Expand DownExpand Up@@ -1450,7 +1450,7 @@ twoline
== %+v
oneline
twoline
github.com/cockroachdb/errors/fmttests.glob...funcNN...
github.com/cockroachdb/errors/fmttests.init.func9
<tab><path>:<lineno>
github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
<tab><path>:<lineno>
Expand DownExpand Up@@ -1487,7 +1487,7 @@ oneline
(1) oneline
| twoline
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func9
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -1528,7 +1528,7 @@ Error types: (1) *errors.fundamental
(1) ‹oneline›
‹ | twoline›
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func9
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -1561,7 +1561,7 @@ Error types: (1) *errors.fundamental
(1) ×
×
-- stack trace:
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
| github.com/cockroachdb/errors/fmttests.init.func9
| <tab><path>:<lineno>
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
| <tab><path>:<lineno>
Expand DownExpand Up@@ -1616,7 +1616,7 @@ Title: "*errors.fundamental: ×"
<path>:<lineno>:
(github.com/cockroachdb/errors/fmttests.TestDatadriven.func2) 1()
<path>:<lineno>:
(github.com/cockroachdb/errors/fmttests.glob.)...funcNN...
(github.com/cockroachdb/errors/fmttests.init)...funcNN...

run
safefmt oneline twoline
Expand Down
Loading