Uh oh!
There was an error while loading. Please reload this page.
build(deps): bump thollander/actions-comment-pull-request from 2.5.0 to 3.0.1 - #2651
Conversation
Up to standards ✅🟢 Issues |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the thollander/actions-comment-pull-request action from v2.5.0 to v3.0.1. Although Codacy reports the changes are up to standards, the version bump introduces a critical breaking change that has not been addressed.
Version 3.x of this action migrated all input parameters to kebab-case. The current implementation maintains the 'comment_tag' parameter, which is no longer supported and will lead to workflow failures or unexpected behavior. This PR should not be merged until the input parameters are aligned with the v3.0.0 specifications.
About this PR
- The update to v3.0.1 involves breaking changes. Specifically, input parameters must be renamed. Failure to migrate these parameters will likely cause the GitHub Action to ignore previous comments or fail to execute correctly.
Test suggestions
- Verify the action version is updated to v3.0.1 in the workflow file.
- Verify that 'comment_tag' is renamed to 'comment-tag' to comply with breaking changes.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that 'comment_tag' is renamed to 'comment-tag' to comply with breaking changes.
TIP Improve review quality by adding custom instructionsTIP How was this review? Give us feedback
| - name: Comment PR if there are deleted files | ||
| if: steps.changed-files.outputs.any_deleted == 'true' | ||
| uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6 # v2 | ||
| uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1 |
There was a problem hiding this comment.
🔴 HIGH RISK
This version bump introduces breaking changes. The input parameter 'comment_tag' must be renamed to 'comment-tag' to remain compatible with version 3.0.1. If left as is, the action may not correctly identify or update existing comments.
Bumps [thollander/actions-comment-pull-request](https://github.com/thollander/actions-comment-pull-request) from 2.5.0 to 3.0.1. - [Release notes](https://github.com/thollander/actions-comment-pull-request/releases) - [Commits](thollander/actions-comment-pull-request@fabd468...24bffb9) --- updated-dependencies: - dependency-name: thollander/actions-comment-pull-request dependency-version: 3.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
049f343 to
d327cb7Compare
Bumps thollander/actions-comment-pull-request from 2.5.0 to 3.0.1.
Release notes
Sourced from thollander/actions-comment-pull-request's releases.
Commits
24bffb9Merge pull request #410 from thollander/chore/release-3.0.15fd7012chore: release 3.0.1a38b001Merge pull request #409 from thollander/fix/wrong-var-renaminga11fbfefix: some wrong variables renamingcb13519Merge pull request #300 from thollander/dependabot/npm_and_yarn/actions/githu...38af97bchore(deps): bump@actions/githubfrom 5.1.1 to 6.0.0301a80eMerge pull request #393 from thollander/dependabot/npm_and_yarn/prettier-3.3.364dcac7chore(deps-dev): bump prettier from 3.2.5 to 3.3.30a327d5Merge pull request #394 from thollander/dependabot/npm_and_yarn/actions/core-...ece12baMerge pull request #392 from thollander/dependabot/npm_and_yarn/vercel/ncc-0....