Uh oh!
There was an error while loading. Please reload this page.
Added the builder to support the do-while task type - #205
Merged
Conversation
boma96
requested changes
May 8, 2025
boma96
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for submission, I left some comments you should check.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Updated Do while task to include value input - Moved loop condition from input to parameter in function
Roruchi
commented
May 9, 2025
ContributorAuthor
Thanks for your feedback @boma96, I have applied the fixes to the latest commit. |
Collaborator
I don't see any issues with this, I hope you will find some problem which can be solved in elegant way using DO_WHILE loops. Will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a builder that enables adding
DO_WHILEtasks to workflow definitions, in line with the official Conductor documentation:🔗 https://conductor-oss.github.io/conductor/documentation/configuration/workflowdef/operators/do-while-task.html
Highlights:
Additionally:
Included an optional fix to allow unit tests to run reliably on some Windows environments.
This builder enables structured looping and retry logic directly within workflows, using native Conductor features in a strongly-typed, maintainable way. Looking forward to your review! 🙌