Skip to content

Added the builder to support the do-while task type - #205

Merged
boma96 merged 2 commits into
codaxy:masterfrom
Roruchi:master
May 14, 2025
Merged

Added the builder to support the do-while task type#205
boma96 merged 2 commits into
codaxy:masterfrom
Roruchi:master

Conversation

@Roruchi

Copy link
Copy Markdown
Contributor

This PR introduces a builder that enables adding DO_WHILE tasks to workflow definitions, in line with the official Conductor documentation:
🔗 https://conductor-oss.github.io/conductor/documentation/configuration/workflowdef/operators/do-while-task.html

Highlights:

  • Adds a DoWhileTaskBuilder and AddTask extension for clean integration into existing workflow definitions.
  • Supports loop conditions
  • Supports fluent configuration of inner tasks via standard builder patterns.
  • Includes a safeguard that prevents nested DO_WHILE blocks, which are not currently supported by Conductor OSS.

Additionally:

Included an optional fix to allow unit tests to run reliably on some Windows environments.

This builder enables structured looping and retry logic directly within workflows, using native Conductor features in a strongly-typed, maintainable way. Looking forward to your review! 🙌

@boma96boma96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submission, I left some comments you should check.

Comment threadtest/ConductorSharp.Engine.Tests/Util/EmbeddedFileHelper.cs Outdated
Comment threadsrc/ConductorSharp.Engine/Model/DoWhileTaskModel.cs Outdated
Comment threadsrc/ConductorSharp.Engine/Model/DoWhileTaskModel.cs
- Updated Do while task to include value input
- Moved loop condition from input to parameter in function
@Roruchi

Copy link
Copy Markdown
ContributorAuthor

Thanks for your feedback @boma96, I have applied the fixes to the latest commit.

@boma96

boma96 commented May 14, 2025

Copy link
Copy Markdown
Collaborator

I don't see any issues with this, I hope you will find some problem which can be solved in elegant way using DO_WHILE loops. Will merge it.

@boma96
boma96 merged commit a8db9e2 into codaxy:masterMay 14, 2025
@rennolajrennolaj mentioned this pull request Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Roruchi@boma96