Uh oh!
There was an error while loading. Please reload this page.
Reader: async ReadOrNullAsync with a nullable result (4.4.0) - #225
Merged
Conversation
…result Restores the async signature; the Try shape forced the method synchronous since async methods cannot have out parameters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
FailedTaskStructuredErrorReader.TryRead(bool +out, synchronous) back to an async method:Task<StructuredError?> ReadOrNullAsync(...). The Try shape forced the method synchronous — async methods cannot haveoutparameters — and blocking on the Conductor call is worse than the null-returning read. The file opts into#nullable enableso the contract is explicit:ReadOrNullAsyncandFindDeepestFailedTaskAsyncmay return null,ReadOrFallbackAsyncnever does.4.4.0 is not on nuget.org yet, so no version bump.
🤖 Generated with Claude Code