Uh oh!
There was an error while loading. Please reload this page.
Include tasks in task_list view - #1146
Conversation
| end | ||
| @preloads [:tasks] | ||
| @preloads [{:tasks, [:comments, :github_pull_request, :task_skills, :user_task]}] |
There was a problem hiding this comment.
This is using nested preloads. I am not sure if we should just add the whole list of task preloads or not. Was just adding them based on the feedback from the tests. @begedin thoughts?
There was a problem hiding this comment.
ah these are the ones marked with identifier: always
There was a problem hiding this comment.
@joshsmith would you also include the task's relationships?
There was a problem hiding this comment.
The real answer here is that it doesn't much matter what I think, but what the performance implications are. Testing this out in the browser with Scout running and doing more precise benchmarking will combined yield a better answer.
snewcomer
commented
Nov 17, 2017
Closing this in favor of #1187 |
Add
includekey to tasks for the task_list viewReferences
Fixes #
Progress on: #