Replace imports with @ember syntax

[snewcomer]

using https://github.com/ember-cli/ember-modules-codemod

References

Fixes#1380

[joshsmith]

Why does coverage drop quite so much here?

[snewcomer]

@joshsmith That is a good question. When looking at this report, it shows red at the points where imports like getProperties were refactored to the new module import syntax.

[joshsmith]

Good observation. My guess is that the getProperties calls were being incorrectly picked up as "covered" even though the actual logic was not really covered.

[joshsmith]

I don't know whether it's realistic to expect to get this coverage back up in the context of this PR. But we definitely would want to open an issue to address it.

Do you have any sense as to whether any other imports were missed by codemod?

Also, this is a tiny stylistic point, but would you mind introducing PRs/commits with "Adds/fixes/removes [verb] whatever the fix was"? I think it brings more clarity to reading the commits (for me, at least) relative to [FEATURE]:[BUG]: etc style.

[snewcomer]

@joshsmith good idea. Lmk if you like the new title. Also, I looked around and it looks like one like this is not replaced and namespace imports import as aren't supported by the addon but don't see any of those.

I don't see testing in this list.

[snewcomer]

Also looks like ember-data and ember-cli-shims is still needed. RFC still open.

[joshsmith]

Good call then. This is a good title rework. I would just amend your commit message with the same and I’ll approve for merge. If you could open an issue for us to go back and fix some of this test coverage that would be great.