Skip to content

chore(ui): drop the unreachable sell branch from swap processing - #622

Merged
bmc08gt merged 1 commit into
chore/remove-newui-beta-flagfrom
chore/drop-dead-sell-branch
Aug 21, 2026
Merged

chore(ui): drop the unreachable sell branch from swap processing#622
bmc08gt merged 1 commit into
chore/remove-newui-beta-flagfrom
chore/drop-dead-sell-branch

Conversation

@bmc08gt

Copy link
Copy Markdown
Collaborator

Stacked on #619 — base it there, not main. Merge that first.

#619 deletes the Currency Sell flow outright (CurrencySellAmountScreen, CurrencySellViewModel, CurrencySellConfirmationScreen, CurrencySellConfirmationViewModel, and their tests), along with the v1 LoadedContent branch of CurrencyInfoScreen where onSell lived. That was the only swapType: .sell call site — Convert replaces it and carries its own case — so nothing constructs a sell any more.

SwapProcessingViewModel still branched on it in four places. This drops case sell from SwapType and the arms it fed in title, subtitle, navigationTitle, and trackTransaction, and updates the two tests that asserted a fourth case and the "Selling TestCoin" title.

Convert keeps reporting through Analytics.tokenSell — it still disposes of the source token — so only the unreachable UI path goes. Session.sell is untouched; Convert calls the same machinery.

Conflict note

feat/usdc-to-dollars-conversion-graphic (commit f3f580a8) touches this same title switch to suppress the "of " suffix when a convert lands in the reserve, and rewrites the targetMint doc comment. Preserve that branch's case .convert where targetMint == .usdf arm and its comment, minus the now-stale "nil on the sell path" clause.

Removing the newUI beta flag deleted the Currency Sell flow, which held the
only `swapType: .sell` call site. Convert replaces it and carries its own
case, so nothing constructs a sell any more.
Drop the case from SwapType and the arms it fed in title, subtitle,
navigationTitle, and trackTransaction. Convert keeps reporting through
Analytics.tokenSell — it still disposes of the source token — so only the
unreachable path goes. The tests asserting a fourth case and the "Selling"
title go with it.
@bmc08gt
bmc08gt merged commit 1224b6e into chore/remove-newui-beta-flagAug 21, 2026
@bmc08gt
bmc08gt deleted the chore/drop-dead-sell-branch branch August 21, 2026 21:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@bmc08gt