Uh oh!
There was an error while loading. Please reload this page.
chore(ui): drop the unreachable sell branch from swap processing - #622
Merged
bmc08gt merged 1 commit intoAug 21, 2026
Merged
Conversation
Removing the newUI beta flag deleted the Currency Sell flow, which held the only `swapType: .sell` call site. Convert replaces it and carries its own case, so nothing constructs a sell any more. Drop the case from SwapType and the arms it fed in title, subtitle, navigationTitle, and trackTransaction. Convert keeps reporting through Analytics.tokenSell — it still disposes of the source token — so only the unreachable path goes. The tests asserting a fourth case and the "Selling" title go with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #619 — base it there, not
main. Merge that first.#619 deletes the Currency Sell flow outright (
CurrencySellAmountScreen,CurrencySellViewModel,CurrencySellConfirmationScreen,CurrencySellConfirmationViewModel, and their tests), along with the v1LoadedContentbranch ofCurrencyInfoScreenwhereonSelllived. That was the onlyswapType: .sellcall site — Convert replaces it and carries its own case — so nothing constructs a sell any more.SwapProcessingViewModelstill branched on it in four places. This dropscase sellfromSwapTypeand the arms it fed intitle,subtitle,navigationTitle, andtrackTransaction, and updates the two tests that asserted a fourth case and the "Selling TestCoin" title.Convert keeps reporting through
Analytics.tokenSell— it still disposes of the source token — so only the unreachable UI path goes.Session.sellis untouched; Convert calls the same machinery.Conflict note
feat/usdc-to-dollars-conversion-graphic(commitf3f580a8) touches this sametitleswitch to suppress the "of " suffix when a convert lands in the reserve, and rewrites thetargetMintdoc comment. Preserve that branch'scase .convert where targetMint == .usdfarm and its comment, minus the now-stale "nil on the sell path" clause.