Skip to content

feat(nx-plugin): adjust bin path handling - #1109

Merged
BioPhoton merged 63 commits into
mainfrom
feat/plugin-nx/allow-unreleased-code
Oct 25, 2025
Merged

feat(nx-plugin): adjust bin path handling#1109
BioPhoton merged 63 commits into
mainfrom
feat/plugin-nx/allow-unreleased-code

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

Precondition:

This PR includes:

  • allows us to execute the repositories code of:
    • cli project'
    • nx-plugin projects executors (not the target inference)
  • removes pluginBin option as it would only help product development and is not working with dependent bundles
  • more intuitive naming

Note

After this is merged is should be possible to use it locally like this:

_nx.json.defaultTargets

"code-pushup": {
"dependsOn": ["cli:build", "nx-plugin:build"],
"executor": "@copde-pushup/nx-plugin:cli",
"options": {
"bin": "./packages/cli/dist",
"env": {
"NODE_OPTIONS": "--import tsx",
"TSX_TSCONFIG_PATH": "tsconfig.base.json"
}
}
}

or

nx.json.plugins

{
"plugin": "@code-pushup/nx-plugin",
"options": {
"bin": "./packages/cli/dist",
"env": {
"NODE_OPTIONS": "--import tsx",
"TSX_TSCONFIG_PATH": "tsconfig.base.json"
}
}
}

Then run: nx code-pushup

You will see a log that prints the executed command as copy past version for you to re-ensure the setup.
NODE_OPTIONS="--import tsx" TSX_TSCONFIG_PATH="tsconfig.base.json" npx @code-pushup/cli --verbose --no-progress --config="code-pushup.config.ts" --upload.project="cli-workspace"

The only thing that is left but blocked by Nx, is using the local target inference code with external dependencies.

Another precondition of:

@github-actionsgithub-actionsBot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin labels Sep 5, 2025
@nx-cloud

nx-cloudBot commented Sep 5, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f8c425a

CommandStatusDurationResult
nx code-pushup --nx-bail -- compare✅ Succeeded54sView ↗
nx code-pushup --nx-bail --✅ Succeeded1m 4sView ↗
nx code-pushup --nx-bail -- print-config --outp...✅ Succeeded3m 42sView ↗

☁️ Nx Cloud last updated this comment at 2025-10-23 15:58:14 UTC

@nx-cloud

nx-cloudBot commented Sep 5, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 695acbc


☁️ Nx Cloud last updated this comment at 2025-09-05 17:32:01 UTC

@pkg-pr-new

pkg-pr-newBot commented Sep 5, 2025

Copy link
Copy Markdown

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1109

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1109

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1109

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1109

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1109

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1109

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1109

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1109

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1109

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1109

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1109

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1109

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1109

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1109

commit: f8c425a

@github-actions

github-actionsBot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 970a665 with previous commit f335d20.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Updates🟡 81🟡 73↓ −7.7
Performance🔴 32🔴 34↑ +1.9
Code coverage🟢 90🟢 90↑ +0.1
Security🟡 56🟡 56
Accessibility🟢 92🟢 92
Best Practices🟢 100🟢 100
SEO🟡 61🟡 61
Type Safety🟢 100🟢 100
Bug prevention🟢 100🟢 100
Miscellaneous🟢 100🟢 100
Code style🟢 100🟢 100
Documentation🔴 36🔴 36
👍 2 groups improved, 👎 1 group regressed, 👍 3 audits improved, 👎 2 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
JS PackagesNPM outdated dependencies🟡 81🟡 73↓ −7.7
LighthousePerformance🔴 32🔴 34↑ +1.9
Code coverageCode coverage metrics🟢 90🟢 90↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseSpeed Index🟥 8.5 s🟥 7.3 s↓ −13.5 %
JS PackagesOutdated NPM dev dependencies.🟨 59 outdated package versions (28 major, 23 minor, 8 patch)🟨 59 outdated package versions (34 major, 17 minor, 8 patch) +0 %
JS PackagesOutdated NPM prod dependencies.🟨 16 outdated package versions (4 major, 8 minor, 4 patch)🟨 16 outdated package versions (6 major, 6 minor, 4 patch) +0 %
LighthouseTotal Blocking Time🟥 2,650 ms🟥 2,110 ms↓ −20.4 %
Code coverageBranch coverage🟨 85.8 %🟨 85.9 %↑ +0.1 %
LighthouseAvoids enormous network payloads🟩 Total size was 2,023 KiB🟩 Total size was 2,019 KiB↓ −0.2 %
LighthouseMinimizes main-thread work🟥 14.6 s🟥 13.5 s↓ −7.8 %
LighthouseLargest Contentful Paint🟥 11.7 s🟥 11.3 s↓ −3.7 %
LighthouseServer Backend Latencies🟩 140 ms🟩 550 ms↑ +298.8 %
LighthouseInitial server response time was short🟥 Root document took 820 ms🟥 Root document took 630 ms↓ −22.9 %
LighthouseMetrics🟩 100%🟩 100%↑ +1.2 %
LighthouseTime to Interactive🟥 13.9 s🟥 14.1 s↑ +1.2 %
LighthouseReduce unused JavaScript🟥 Potential savings of 180 KiB🟥 Potential savings of 180 KiB↑ +21.3 %
LighthouseRemove duplicate modules in JavaScript bundles🟥 Potential savings of 101 KiB🟥 Potential savings of 103 KiB↑ +53.3 %
LighthouseUses efficient cache policy on static assets🟨 30 resources found🟨 30 resources found↓ −0.1 %
LighthouseMax Potential First Input Delay🟥 1,660 ms🟥 1,580 ms↓ −4.8 %
LighthouseJavaScript execution time🟥 5.7 s🟥 5.6 s↓ −1.2 %
LighthouseNetwork Round Trip Times🟩 60 ms🟩 40 ms↓ −41.2 %
LighthouseFirst Contentful Paint🟥 3.2 s🟥 3.2 s↓ −0.4 %
LighthouseReduce unused CSS🟥 Potential savings of 103 KiB🟥 Potential savings of 103 KiB↑ +2.2 %
Code coverageLine coverage🟨 86.6 %🟨 86.6 %↑ +0.1 %

589 other audits are unchanged.

@BioPhoton
BioPhoton marked this pull request as ready for review September 5, 2025 17:29
@github-actionsgithub-actionsBot removed the 📖 Project documentation improvements or additions to the project documentation label Sep 9, 2025
@github-actionsgithub-actionsBot added the 📖 Project documentation improvements or additions to the project documentation label Oct 4, 2025
Comment threadpackages/nx-plugin/src/executors/cli/executor.ts Outdated
Comment threadpackages/nx-plugin/src/plugin/target/executor-target.ts Outdated
Comment threadpackages/nx-plugin/src/plugin/target/executor.target.unit.test.ts Outdated
BioPhotonand others added 5 commits October 23, 2025 17:41
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
…code' into feat/plugin-nx/allow-unreleased-code
@BioPhoton
BioPhoton merged commit fbb5c9b into mainOct 25, 2025
21 of 22 checks passed
@BioPhoton
BioPhoton deleted the feat/plugin-nx/allow-unreleased-code branch October 25, 2025 01:17
BioPhoton added a commit that referenced this pull request Dec 2, 2025
related to #1091 **This PR includes:**
- alignments of terminal args helper
- add command formatter helper to `utils`
- reuse utils in `nx-plugin` and remove old code
- remove bin logic from config target (left over of #1109)
---------
Co-authored-by: John Doe <john.doe@example.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 nx-plugin📖 Project documentationimprovements or additions to the project documentation🔬 testingwriting tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BioPhoton@matejchalk