Skip to content

test(utils): add test cases for valid and invalid spinner usages - #1147

Merged
matejchalk merged 1 commit into
mainfrom
test-sequential-spinners
Nov 14, 2025
Merged

test(utils): add test cases for valid and invalid spinner usages#1147
matejchalk merged 1 commit into
mainfrom
test-sequential-spinners

Conversation

@matejchalk

@matejchalkmatejchalk commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator

Added a few test cases while trying to figure out the cause of #1145 (review).

@nx-cloud

nx-cloudBot commented Nov 14, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d12f810

CommandStatusDurationResult
nx code-pushup --nx-bail -- compare✅ Succeeded1m 2sView ↗
nx code-pushup --nx-bail --✅ Succeeded1m 8sView ↗
nx code-pushup --nx-bail -- print-config --outp...✅ Succeeded4m 31sView ↗

☁️ Nx Cloud last updated this comment at 2025-11-14 16:59:21 UTC

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1147

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1147

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1147

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1147

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1147

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1147

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1147

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1147

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1147

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1147

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1147

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1147

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1147

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1147

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1147

commit: d12f810

@matejchalk
matejchalk marked this pull request as ready for review November 14, 2025 16:56
@github-actions

Copy link
Copy Markdown
Contributor

Code PushUp

😟 Code PushUp report has regressed – compared current commit 507703e with previous commit c90eea2.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Security🟡 56🔴 35↓ −21.1
Performance🔴 35🔴 32↓ −3.4
Code coverage🟡 88🟡 88
Updates🟡 75🟡 75
Accessibility🟢 92🟢 92
Best Practices🟢 100🟢 100
SEO🟡 61🟡 61
Type Safety🟢 100🟢 100
Bug prevention🟢 100🟢 100
Miscellaneous🟢 100🟢 100
Code style🟢 100🟢 100
Documentation🔴 35🔴 35
👎 2 groups regressed, 👎 5 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
JS PackagesNPM audit🟡 56🔴 35↓ −21.1
LighthousePerformance🔴 35🔴 32↓ −3.4

21 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
JS PackagesVulnerabilities for NPM prod dependencies.🟨 9 vulnerabilities (2 high, 7 low)🟥 14 vulnerabilities (2 high, 5 moderate, 7 low)↑ +55.6 %
LighthouseFirst Contentful Paint🟨 3.0 s🟥 3.7 s↑ +24.1 %
LighthouseSpeed Index🟥 6.6 s🟥 7.3 s↑ +11.8 %
LighthouseTotal Blocking Time🟥 2,430 ms🟥 2,680 ms↑ +10.5 %
LighthouseTime to Interactive🟥 13.3 s🟥 13.3 s↑ +0.1 %
LighthouseAvoids enormous network payloads🟩 Total size was 2,034 KiB🟩 Total size was 2,011 KiB↓ −1.1 %
LighthouseMinimizes main-thread work🟥 13.3 s🟥 14.5 s↑ +8.5 %
LighthouseServer Backend Latencies🟩 1,230 ms🟩 840 ms↓ −32.1 %
LighthouseUses efficient cache policy on static assets🟨 30 resources found🟨 30 resources found↑ +0.1 %
LighthouseMax Potential First Input Delay🟥 1,060 ms🟥 1,440 ms↑ +35.8 %
LighthouseReduce unused CSS🟥 Potential savings of 105 KiB🟥 Potential savings of 72 KiB↓ −59.2 %
LighthouseJavaScript execution time🟥 4.9 s🟥 5.1 s↑ +3.1 %
LighthouseLargest Contentful Paint🟥 11.3 s🟥 11.2 s↓ −1.1 %
LighthouseReduce unused JavaScript🟥 Potential savings of 183 KiB🟥 Potential savings of 183 KiB↑ +8.2 %
LighthouseInitial server response time was short🟩 Root document took 560 ms🟩 Root document took 490 ms↓ −12.6 %
LighthouseRemove duplicate modules in JavaScript bundles🟥 Potential savings of 102 KiB🟥 Potential savings of 103 KiB↓ −8.2 %
JS PackagesVulnerabilities for NPM dev dependencies.🟥 28 vulnerabilities (1 critical, 19 moderate, 8 low)🟥 54 vulnerabilities (1 critical, 45 moderate, 8 low)↑ +92.9 %
LighthouseNetwork Round Trip Times🟩 50 ms🟩 70 ms↑ +42.5 %
LighthouseMetrics🟩 100%🟩 100%↑ +0.1 %
Code coverageBranch coverage🟨 86.7 %🟨 86.7 %↓ −0.1 %

658 other audits are unchanged.

@matejchalk
matejchalk merged commit 09b2adb into mainNov 14, 2025
23 of 24 checks passed
@matejchalk
matejchalk deleted the test-sequential-spinners branch November 14, 2025 17:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@matejchalk@vmasek