Skip to content

refactor: update to nx 22 - #1196

Merged
BioPhoton merged 24 commits into
mainfrom
chore/update-to-nx-22
Dec 29, 2025
Merged

refactor: update to nx 22#1196
BioPhoton merged 24 commits into
mainfrom
chore/update-to-nx-22

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

This PR includes:

  • package version updates over running nx migrate latest
  • ☝️ plugin-typescriptint-test updates due to 2 errors less introduces by version update (errors are not in our source code but in node_modules)
  • ☝️ plugin-typescript-e2ee2e-test updates due to 2 errors less introduces by version update (errors are not in our source code but in node_modules)
  • adjustments of test target defaults and e2e tests project targets (fixed a miss configuration and also could delete options)
  • added tests for createNodesV2 in nx-plugin
  • deleted logic and tests for createNodes in nx-plugin as not present in Nx v22

closes#1173

@nx-cloud

nx-cloudBot commented Dec 20, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit b7d7eac

CommandStatusDurationResult
nx run ci:code-pushup -- merge-diffs --files=/h...✅ Succeeded5sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded1m 24sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded12m 19sView ↗
nx run-many -t unit-test,int-test✅ Succeeded47sView ↗

☁️ Nx Cloud last updated this comment at 2025-12-27 18:21:21 UTC

@pkg-pr-new

pkg-pr-newBot commented Dec 21, 2025

Copy link
Copy Markdown

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1196

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1196

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1196

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1196

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1196

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1196

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1196

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1196

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1196

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1196

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1196

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1196

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1196

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1196

commit: b7d7eac

@github-actions

github-actionsBot commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 20ec9e8 with previous commit 4f51446.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Security🔴 43🟡 51↑ +8.4
Updates🟡 71🟡 79↑ +7.7
Performance🔴 47🔴 41↓ −5.7
Code coverage🟡 89🟡 89↑ +0.2
Documentation🔴 36🔴 36↓ −0.1
Axe Accessibility🟡 88🟡 88↓ −0.1
Bug prevention🟡 67🟡 67
Code style🟢 99🟢 99
Type Safety🟡 56🟡 56
Miscellaneous🟡 67🟡 67
Accessibility🟢 92🟢 92
Best Practices🟢 100🟢 100
SEO🟢 92🟢 92
👍 3 groups improved, 👎 2 groups regressed, 👍 9 audits improved, 👎 6 audits regressed, 18 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
JS packagesnpm audit🔴 43🟡 51↑ +8.4
JS packagesnpm outdated dependencies🟡 71🟡 79↑ +7.7
LighthousePerformance🔴 47🔴 41↓ −5.7
Code coverageCode coverage metrics🟡 89🟡 89↑ +0.2
JSDocs coverageDocumentation coverage🔴 36🔴 36↓ −0.1

29 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseInitial server response time was short🟥 Root document took 1,350 ms🟩 Root document took 390 ms↓ −71.2 %
LighthouseTotal Blocking Time🟥 700 ms🟥 1,180 ms↑ +67.6 %
LighthouseMax Potential First Input Delay🟥 420 ms🟥 1,120 ms↑ +169.2 %
JS packagesVulnerabilities for npm prod dependencies.🟨 11 vulnerabilities (3 high, 1 moderate, 7 low)🟨 10 vulnerabilities (2 high, 1 moderate, 7 low)↓ −9.1 %
JS packagesOutdated npm dev dependencies.🟨 61 outdated package versions (35 major, 19 minor, 7 patch)🟨 53 outdated package versions (28 major, 19 minor, 6 patch)↓ −13.1 %
JS packagesOutdated npm prod dependencies.🟨 18 outdated package versions (7 major, 8 minor, 3 patch)🟨 16 outdated package versions (5 major, 8 minor, 3 patch)↓ −11.1 %
LighthouseSpeed Index🟥 6.3 s🟥 5.9 s↓ −6.8 %
LighthouseTime to Interactive🟥 11.4 s🟥 12.7 s↑ +12 %
LighthouseFirst Contentful Paint🟥 3.0 s🟥 3.1 s↑ +1.6 %
JSDocs coverageVariables coverage🟥 267 undocumented variables🟥 267 undocumented variables +0 %
Code coverageFunction coverage🟩 90.6 %🟩 90.9 %↑ +0.3 %
Code coverageLine coverage🟨 84.6 %🟨 84.7 %↑ +0.1 %
JSDocs coverageTypes coverage🟥 247 undocumented types🟥 246 undocumented types↓ −0.4 %
JSDocs coverageFunctions coverage🟥 588 undocumented functions🟥 587 undocumented functions↓ −0.2 %
Code coverageBranch coverage🟨 87.2 %🟨 87.2 %↓ −0.1 %
LighthouseAvoids enormous network payloads🟩 Total size was 2,057 KiB🟩 Total size was 2,048 KiB↓ −0.4 %
LighthouseMinimizes main-thread work🟥 5.7 s🟥 8.8 s↑ +55.9 %
LighthouseLargest Contentful Paint🟥 9.5 s🟥 11.2 s↑ +18.8 %
LighthouseJavaScript execution time🟥 2.1 s🟥 3.7 s↑ +80.9 %
LighthouseMetrics🟩 100%🟩 100%↑ +12 %
LighthouseServer Backend Latencies🟩 1,300 ms🟩 220 ms↓ −83.1 %
LighthouseUses efficient cache policy on static assets🟨 30 resources found🟨 30 resources found↓ −0.1 %
LighthouseRemove duplicate modules in JavaScript bundles🟥 Potential savings of 105 KiB🟥 Potential savings of 105 KiB↑ +48.4 %
TypeScriptSemantic errors🟥 2602 errors🟥 2581 errors↓ −0.8 %
LighthouseReduce unused JavaScript🟥 Potential savings of 190 KiB🟥 Potential savings of 190 KiB↓ −1.1 %
AxeARIA attributes must conform to valid values🟥 8 errors🟥 1 error↓ −87.5 %
JS packagesVulnerabilities for npm dev dependencies.🟥 30 vulnerabilities (1 critical, 6 high, 18 moderate, 5 low)🟥 24 vulnerabilities (3 critical, 6 high, 9 moderate, 6 low)↓ −20 %
AxeElements must only use supported ARIA attributes🟩 96 elements🟩 93 elements↓ −3.1 %
AxeARIA attributes must be used as specified for the element's role🟩 96 elements🟩 93 elements↓ −3.1 %
AxeElements must only use permitted ARIA attributes🟩 96 elements🟩 93 elements↓ −3.1 %
AxeARIA attributes must conform to valid names🟩 96 elements🟩 93 elements↓ −3.1 %
LighthouseNetwork Round Trip Times🟩 10 ms🟩 10 ms↑ +9.3 %
LighthouseCumulative Layout Shift🟩 0🟩 0↑ +∞ %

646 other audits are unchanged.

@github-actions

github-actionsBot commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 20ec9e8 with previous commit 4f51446.

💼 Project nx-plugin

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟡 85🟡 89↑ +4.6
Documentation🟡 65🟡 64↓ −1.1

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed, 2 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟡 85🟡 89↑ +4.6
JSDocs coverageDocumentation coverage🟡 65🟡 64↓ −1.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
JSDocs coverageVariables coverage🟥 7 undocumented variables🟥 7 undocumented variables +0 %
Code coverageFunction coverage🟩 90 %🟩 96.4 %↑ +7.1 %
Code coverageLine coverage🟨 79.7 %🟨 84.8 %↑ +6.4 %
Code coverageBranch coverage🟨 75.6 %🟨 76.3 %↑ +0.9 %
JSDocs coverageTypes coverage🟥 15 undocumented types🟥 14 undocumented types↓ −6.7 %
JSDocs coverageFunctions coverage🟥 20 undocumented functions🟥 19 undocumented functions↓ −5 %

442 other audits are unchanged.


13 other projects are unchanged.

@BioPhoton
BioPhoton marked this pull request as ready for review December 21, 2025 00:35
@BioPhoton
BioPhoton requested review from matejchalk and removed request for matejchalkDecember 21, 2025 01:29
@BioPhoton
BioPhoton marked this pull request as draft December 21, 2025 01:48
@BioPhotonBioPhoton mentioned this pull request Dec 21, 2025
10 tasks
@BioPhoton
BioPhoton marked this pull request as ready for review December 21, 2025 02:31
@BioPhoton
BioPhoton enabled auto-merge (squash) December 21, 2025 02:38
Comment threade2e/plugin-js-packages-e2e/project.json Outdated
Comment threadpackages/nx-plugin/src/plugin/types.ts
Comment threadpackages/nx-plugin/src/plugin/plugin.unit.test.ts Outdated
Comment threadpackages/nx-plugin/src/executors/cli/utils.unit.test.ts
Comment threadpackages/nx-plugin/src/plugin/plugin.unit.test.ts
Comment threadpackages/nx-plugin/src/plugin/utils.unit.test.ts
@BioPhoton
BioPhoton merged commit fbc637b into mainDec 29, 2025
24 checks passed
@BioPhoton
BioPhoton deleted the chore/update-to-nx-22 branch December 29, 2025 13:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Nx 22

2 participants

@BioPhoton@hanna-skryl