feat: add process exit handler by BioPhoton · Pull Request #1212 · code-pushup/cli

BioPhoton · 2026-01-12T01:34:55Z

related to #1197

This PR includes:

adjustments for performance observer buffering
add exit-process utils

nx-cloud · 2026-01-12T01:36:19Z

View your CI Pipeline Execution ↗ for commit ad85170

Command	Status	Duration	Result
`nx run ci:code-pushup -- merge-diffs --files=/h...`	✅ Succeeded	5s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	1m 25s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	12m 26s	View ↗
`nx run-many -t unit-test,int-test`	✅ Succeeded	1m 20s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-14 01:15:53 UTC

pkg-pr-new · 2026-01-12T01:36:31Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1212

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1212

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1212

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1212

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1212

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1212

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1212

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1212

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1212

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1212

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1212

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1212

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1212

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1212

commit: ad85170

github-actions · 2026-01-12T01:43:06Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit efc4fe5 with previous commit 7d3681c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 37	🔴 35
Documentation	🔴 34	🔴 34
Code coverage	🟢 91	🟢 91
Bug prevention	🟡 75	🟡 75
Axe Accessibility	🟡 88	🟡 88
Code style	🟢 99	🟢 99	–
Security	🟡 51	🟡 51	–
Updates	🟡 78	🟡 78	–
Type Safety	🟡 67	🟡 67	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟢 92	🟢 92	–

👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 8 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Lighthouse	Performance	🔴 37	🔴 35
JSDocs coverage	Documentation coverage	🔴 34	🔴 34
Code coverage	Code coverage metrics	🟢 91	🟢 91

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Speed Index	🟥 5.9 s	🟥 6.6 s
Lighthouse	First Contentful Paint	🟥 3.0 s	🟥 3.3 s
Lighthouse	Time to Interactive	🟥 13.0 s	🟥 13.5 s
Lighthouse	Total Blocking Time	🟥 1,990 ms	🟥 2,050 ms
JSDocs coverage	Types coverage	🟥 260 undocumented types	🟥 265 undocumented types
Code coverage	Line coverage	🟨 86.2 %	🟨 86.2 %
Code coverage	Branch coverage	🟨 87.3 %	🟨 87.3 %
JSDocs coverage	Variables coverage	🟥 271 undocumented variables	🟥 275 undocumented variables
Code coverage	Function coverage	🟩 93.4 %	🟩 93.4 %
JSDocs coverage	Functions coverage	🟥 597 undocumented functions	🟥 598 undocumented functions
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,113 KiB	🟩 Total size was 2,112 KiB
Lighthouse	Server Backend Latencies	🟩 1,050 ms	🟩 310 ms
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Uses efficient cache policy on static assets	🟨 31 resources found	🟨 31 resources found
Lighthouse	Max Potential First Input Delay	🟥 1,040 ms	🟥 1,270 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 95 KiB	🟥 Potential savings of 84 KiB
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 200 KiB	🟥 Potential savings of 223 KiB
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 103 KiB	🟥 Potential savings of 109 KiB
Lighthouse	Initial server response time was short	🟩 Root document took 400 ms	🟩 Root document took 540 ms
Lighthouse	JavaScript execution time	🟥 4.4 s	🟥 4.3 s
Lighthouse	Network Round Trip Times	🟩 0 ms	🟩 70 ms
Lighthouse	Minimizes main-thread work	🟥 8.9 s	🟥 8.9 s
Lighthouse	Largest Contentful Paint	🟥 11.4 s	🟥 11.4 s
JS packages	Outdated npm dev dependencies.	🟨 55 outdated package versions (29 major, 19 minor, 7 patch)	🟨 56 outdated package versions (29 major, 19 minor, 8 patch)
JSDocs coverage	Properties coverage	🟥 24 undocumented properties	🟥 23 undocumented properties

654 other audits are unchanged.

github-actions · 2026-01-12T01:50:26Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit efc4fe5 with previous commit 7d3681c.

💼 Project `utils`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🔴 36	🔴 36
Code coverage	🟢 94	🟢 94

4 other categories are unchanged.

👎 2 groups regressed, 👍 2 audits improved, 👎 4 audits regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDocs coverage	Documentation coverage	🔴 36	🔴 36
Code coverage	Code coverage metrics	🟢 94	🟢 94

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Types coverage	🟥 59 undocumented types	🟥 64 undocumented types
Code coverage	Branch coverage	🟩 91.8 %	🟩 91.6 %
JSDocs coverage	Variables coverage	🟥 43 undocumented variables	🟥 47 undocumented variables
Code coverage	Line coverage	🟩 93.8 %	🟩 93.9 %
Code coverage	Function coverage	🟩 95.8 %	🟩 95.9 %
JSDocs coverage	Functions coverage	🟥 246 undocumented functions	🟥 247 undocumented functions
JSDocs coverage	Properties coverage	🟥 24 undocumented properties	🟥 23 undocumented properties

437 other audits are unchanged.

13 other projects are unchanged.

BioPhoton · 2026-01-12T15:52:14Z

I will add int tests now that i examined the logger code.☝️

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

hanna-skryl

Nice work!

matejchalk · 2026-01-15T09:39:22Z

+export const SIGNAL_EXIT_CODES = (): Record<SignalName, number> => {
+ const isWindowsRuntime = os.platform() === 'win32';
+ return {
+ SIGINT: isWindowsRuntime ? SIGINT_CODE : unixSignalExitCode(SIGINT_CODE),
+ SIGTERM: unixSignalExitCode(SIGTERM_CODE),
+ SIGQUIT: unixSignalExitCode(SIGQUIT_CODE),
+ };
+};


⚠️@BioPhoton, it's not just SIGINT that has different exit code offsets per OS. The conditional logic should be applied for all signals, including SIGTERM and SIGQUIT.

fix: add process exit handler
586a93f

github-actionsBot assigned BioPhoton Jan 12, 2026

github-actionsBot added 🔬 testing writing tests 🧩 utils labels Jan 12, 2026

BioPhoton mentioned this pull request Jan 12, 2026
Implement performance profiling and trace file generation #1197
Open

BioPhoton marked this pull request as ready for review January 12, 2026 02:05

BioPhoton requested a review from hanna-skryl January 12, 2026 02:22

hanna-skryl reviewed Jan 12, 2026
View reviewed changes

Comment threadpackages/utils/src/lib/exit-process.ts Outdated
Comment threadpackages/utils/src/lib/exit-process.ts Outdated

John Doe added 4 commits January 12, 2026 18:45

refactor: add int tests and refactor for reuse
71efc34

refactor: add no double close test
8467290

refactor: fix int test
177355e

refactor: fix lint
6950284

BioPhoton requested a review from hanna-skryl January 12, 2026 18:12

hanna-skryl reviewed Jan 12, 2026
View reviewed changes

Comment threadpackages/utils/src/lib/exit-process.int.test.ts Outdated

John Doe added 3 commits January 13, 2026 20:12

refactor: add better flush handling
fb34061

refactor: rename options
896fb75

refactor: add test
c84ea01

BioPhoton requested a review from hanna-skryl January 13, 2026 19:32

hanna-skryl reviewed Jan 14, 2026
View reviewed changes

Comment threadpackages/utils/src/lib/performance-observer.ts Outdated

Update packages/utils/src/lib/performance-observer.ts
ad85170
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

BioPhoton requested a review from hanna-skryl January 14, 2026 01:00

hanna-skryl approved these changes Jan 14, 2026
View reviewed changes

BioPhoton merged commit 0daf9f1 into mainJan 14, 2026
27 checks passed

BioPhoton deleted the feat/utils/exit-handler branch January 14, 2026 01:17

matejchalk reviewed Jan 15, 2026
View reviewed changes

Navigation Menu

Uh oh!

feat: add process exit handler - #1212

feat: add process exit handler#1212
BioPhoton merged 9 commits into
mainfrom
feat/utils/exit-handler

BioPhoton commented Jan 12, 2026•
edited
Loading

Uh oh!

nx-cloudBot commented Jan 12, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Jan 12, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Jan 12, 2026•
edited
Loading

🗃️ Groups

🛡️ Audits

Uh oh!

github-actionsBot commented Jan 12, 2026•
edited
Loading

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

BioPhoton commented Jan 12, 2026

Uh oh!

Uh oh!

Uh oh!

hanna-skryl left a comment

Uh oh!

Uh oh!

matejchalkJan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

BioPhoton commented Jan 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloudBot commented Jan 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Jan 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jan 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

github-actionsBot commented Jan 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project utils

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

BioPhoton commented Jan 12, 2026

Uh oh!

Uh oh!

Uh oh!

hanna-skryl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matejchalkJan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BioPhoton commented Jan 12, 2026•
edited
Loading

nx-cloudBot commented Jan 12, 2026•
edited
Loading

pkg-pr-newBot commented Jan 12, 2026•
edited
Loading

github-actionsBot commented Jan 12, 2026•
edited
Loading

github-actionsBot commented Jan 12, 2026•
edited
Loading

💼 Project `utils`