Skip to content

refactor: remove noise files from test coverage - #1214

Merged
poltorak merged 2 commits into
mainfrom
refactor/test-coverage-noise
Jan 14, 2026
Merged

refactor: remove noise files from test coverage#1214
poltorak merged 2 commits into
mainfrom
refactor/test-coverage-noise

Conversation

@poltorak

Copy link
Copy Markdown
Collaborator

Covers part 3 of #1168

Added more files to be excluded in test coverage report

@poltorakpoltorak self-assigned this Jan 12, 2026
@github-actionsgithub-actionsBot added the 🔬 testing writing tests label Jan 12, 2026
@nx-cloud

nx-cloudBot commented Jan 12, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit bd747d0

CommandStatusDurationResult
nx run ci:code-pushup -- merge-diffs --files=/h...✅ Succeeded5sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded1m 25sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded12m 32sView ↗

☁️ Nx Cloud last updated this comment at 2026-01-13 17:00:21 UTC

@pkg-pr-new

pkg-pr-newBot commented Jan 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1214

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1214

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1214

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1214

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1214

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1214

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1214

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1214

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1214

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1214

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1214

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1214

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1214

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1214

commit: bd747d0

@github-actions

github-actionsBot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit bf38c72 with previous commit 7d3681c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🔴 37🔴 34↓ −3.5
Code coverage🟢 91🟢 92↑ +1.6
Bug prevention🟡 75🟡 75↓ −0.1
Axe Accessibility🟡 88🟡 88↓ −0.1
Documentation🔴 34🔴 34↓ −0.1
Code style🟢 99🟢 99
Security🟡 51🟡 51
Updates🟡 78🟡 78
Type Safety🟡 67🟡 67
Miscellaneous🟡 67🟡 67
Accessibility🟢 92🟢 92
Best Practices🟢 100🟢 100
SEO🟢 92🟢 92
👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 5 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🔴 37🔴 34↓ −3.5
Code coverageCode coverage metrics🟢 91🟢 92↑ +1.6
JSDocs coverageDocumentation coverage🔴 34🔴 34↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseInitial server response time was short🟩 Root document took 400 ms🟥 Root document took 660 ms↑ +66.5 %
LighthouseSpeed Index🟥 5.9 s🟥 7.5 s↑ +27.2 %
Code coverageLine coverage🟨 86.2 %🟩 92.5 %↑ +7.4 %
LighthouseFirst Contentful Paint🟥 3.0 s🟥 3.1 s↑ +3.9 %
LighthouseTime to Interactive🟥 13.0 s🟥 14.3 s↑ +9.6 %
LighthouseTotal Blocking Time🟥 1,990 ms🟥 2,440 ms↑ +22.5 %
Code coverageBranch coverage🟨 87.3 %🟨 89 %↑ +1.9 %
Code coverageFunction coverage🟩 93.4 %🟩 94.1 %↑ +0.8 %
LighthouseMinimizes main-thread work🟥 8.9 s🟥 11.1 s↑ +24.9 %
LighthouseAvoids enormous network payloads🟩 Total size was 2,113 KiB🟩 Total size was 2,111 KiB↓ −0.1 %
LighthouseMetrics🟩 100%🟩 100%↑ +9.6 %
LighthouseJavaScript execution time🟥 4.4 s🟥 5.4 s↑ +22.5 %
LighthouseServer Backend Latencies🟩 1,050 ms🟩 230 ms↓ −78.4 %
LighthouseUses efficient cache policy on static assets🟨 31 resources found🟨 31 resources found↑ +0.1 %
LighthouseLargest Contentful Paint🟥 11.4 s🟥 12.0 s↑ +4.7 %
LighthouseMax Potential First Input Delay🟥 1,040 ms🟥 1,460 ms↑ +39.9 %
LighthouseReduce unused CSS🟥 Potential savings of 95 KiB🟥 Potential savings of 95 KiB↓ −25 %
LighthouseReduce unused JavaScript🟥 Potential savings of 200 KiB🟥 Potential savings of 223 KiB↑ +14.2 %
LighthouseNetwork Round Trip Times🟩 0 ms🟩 20 ms↑ +227.1 %
JS packagesOutdated npm dev dependencies.🟨 55 outdated package versions (29 major, 19 minor, 7 patch)🟨 56 outdated package versions (29 major, 19 minor, 8 patch)↑ +1.8 %

659 other audits are unchanged.

@github-actions

github-actionsBot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit bf38c72 with previous commit 7d3681c.

💼 Project create-cli

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 90🟢 96↑ +5.6

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 90🟢 96↑ +5.6

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟨 82.5 %🟩 97 %↑ +17.7 %
Code coverageBranch coverage🟨 73.7 %🟨 87.5 %↑ +18.8 %

442 other audits are unchanged.

💼 Project nx-plugin

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟡 89🟢 91↑ +2.2

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟡 89🟢 91↑ +2.2

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟨 84.8 %🟩 93.2 %↑ +9.8 %
Code coverageBranch coverage🟨 76.3 %🟨 80.8 %↑ +6 %

446 other audits are unchanged.

💼 Project plugin-jsdocs

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 95🟢 97↑ +1.9

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 95🟢 97↑ +1.9

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟩 90.5 %🟩 96 %↑ +6.1 %
Code coverageBranch coverage🟨 87.9 %🟩 92.5 %↑ +5.2 %

442 other audits are unchanged.

💼 Project cli

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 92🟢 94↑ +1.4

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 92🟢 94↑ +1.4

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟨 88.5 %🟩 94.5 %↑ +6.7 %
Code coverageBranch coverage🟨 84.2 %🟨 86.9 %↑ +3.3 %

442 other audits are unchanged.

💼 Project plugin-axe

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 93🟢 94↑ +1.4

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 93🟢 94↑ +1.4

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageBranch coverage🟨 86.3 %🟩 90.1 %↑ +4.4 %
Code coverageLine coverage🟨 69.7 %🟨 72.2 %↑ +3.6 %

441 other audits are unchanged.

💼 Project plugin-typescript

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟡 86🟡 87↑ +1.3

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟡 86🟡 87↑ +1.3

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟩 90.7 %🟩 95.5 %↑ +5.3 %
Code coverageBranch coverage🟨 77.7 %🟨 80.2 %↑ +3.3 %

442 other audits are unchanged.

💼 Project plugin-lighthouse

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 99🟢 99↑ +1

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 99🟢 99↑ +1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟩 97.2 %🟩 99.8 %↑ +2.7 %
Code coverageBranch coverage🟩 96.2 %🟩 98.8 %↑ +2.7 %

442 other audits are unchanged.

💼 Project models

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 93🟢 94↑ +1

3 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 93🟢 94↑ +1

11 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageBranch coverage🟩 91.5 %🟩 94.2 %↑ +2.9 %
Code coverageLine coverage🟩 97.2 %🟩 99.4 %↑ +2.2 %

435 other audits are unchanged.

💼 Project ci

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 92🟢 92↑ +0.9

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 92🟢 92↑ +0.9

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟨 89.7 %🟩 94.8 %↑ +5.7 %
Code coverageBranch coverage🟨 82.4 %🟨 83.6 %↑ +1.5 %
Code coverageFunction coverage🟩 96.6 %🟩 96.6 %↓ −0.1 %

442 other audits are unchanged.

💼 Project core

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟡 90🟢 90↑ +0.8

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟡 90🟢 90↑ +0.8

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟩 91.2 %🟩 94.8 %↑ +3.9 %
Code coverageBranch coverage🟨 81.7 %🟨 83.2 %↑ +1.8 %

442 other audits are unchanged.

💼 Project plugin-coverage

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟡 89🟢 90↑ +0.7

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟡 89🟢 90↑ +0.7

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟨 85.7 %🟨 88 %↑ +2.7 %
Code coverageBranch coverage🟨 88.1 %🟨 89.6 %↑ +1.7 %

442 other audits are unchanged.

💼 Project plugin-eslint

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 94🟢 94↑ +0.6

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 94🟢 94↑ +0.6

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟩 92.6 %🟩 95 %↑ +2.5 %
Code coverageBranch coverage🟨 85.2 %🟨 86.5 %↑ +1.5 %
Code coverageFunction coverage🟩 98.2 %🟩 98.2 %↓ −0.1 %

441 other audits are unchanged.

💼 Project plugin-js-packages

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟡 85🟡 86↑ +0.6

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟡 85🟡 86↑ +0.6

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageBranch coverage🟩 93.3 %🟩 95 %↑ +1.8 %
Code coverageLine coverage🟨 85 %🟨 85.8 %↑ +0.9 %

442 other audits are unchanged.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟢 94🟢 95↑ +0.4
Documentation🔴 36🔴 36↑ +0.1

4 other categories are unchanged.

👍 2 groups improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟢 94🟢 95↑ +0.4
JSDocs coverageDocumentation coverage🔴 36🔴 36↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageLine coverage🟩 93.8 %🟩 97.4 %↑ +3.8 %
Code coverageBranch coverage🟩 91.8 %🟩 92.1 %↑ +0.3 %

442 other audits are unchanged.

@BioPhotonBioPhoton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestio for type handling and including the tests folder.

Comment threadtesting/test-setup-config/src/lib/vitest-config-factory.ts Outdated
Comment threadtesting/test-setup-config/src/lib/vitest-config-factory.ts Outdated
@BioPhoton

Copy link
Copy Markdown
Collaborator

Another idea... we could run-many unit-test and int test and ask AI to analyse for noise files. If it works the prompt could be attached to the PR description.

@poltorak

poltorak commented Jan 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Another idea... we could run-many unit-test and int test and ask AI to analyse for noise files. If it works the prompt could be attached to the PR description.

Not sure you meant by attaching prompt to description, however I ran AI against the coverage report, it suggested (mistakenly) to add some more files which actually contained methods. The only worth advice from it was to also add constants.ts, *.mock and fixtures/* files which I added

@poltorak
poltorak merged commit b2f4467 into mainJan 14, 2026
26 of 28 checks passed
@poltorak
poltorak deleted the refactor/test-coverage-noise branch January 14, 2026 09:17
@BioPhotonBioPhoton mentioned this pull request Feb 3, 2026
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@poltorak@BioPhoton