Uh oh!
There was an error while loading. Please reload this page.
feat(plugin-coverage): add setup wizard binding - #1273
Conversation
View your CI Pipeline Execution ↗ for commit c0584a5
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci@code-pushup/cli@code-pushup/core@code-pushup/create-cli@code-pushup/models@code-pushup/nx-plugin@code-pushup/axe-plugin@code-pushup/coverage-plugin@code-pushup/eslint-plugin@code-pushup/js-packages-plugin@code-pushup/jsdocs-plugin@code-pushup/lighthouse-plugin@code-pushup/typescript-plugin@code-pushup/utilscommit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit f620c71 with previous commit 28ccfcb. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 3 groups improved, 👎 1 group regressed, 👍 8 audits improved, 👎 3 audits regressed, 14 audits changed without impacting score🗃️ Groups
30 other groups are unchanged. 🛡️ Audits
653 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit f620c71 with previous commit 28ccfcb. 💼 Project |
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 92 | 🟢 93 | |
| Documentation | 🟡 69 | 🟡 68 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed, 2 audits changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 92 | 🟢 93 | |
| JSDocs coverage | Documentation coverage | 🟡 69 | 🟡 68 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Functions coverage | 🟥 22 undocumented functions | 🟥 33 undocumented functions | |
| Code coverage | Function coverage | 🟩 93.5 % | 🟩 95.7 % | |
| Code coverage | Line coverage | 🟨 89.1 % | 🟩 91 % | |
| Code coverage | Branch coverage | 🟨 89.6 % | 🟨 89.7 % | |
| JSDocs coverage | Variables coverage | 🟥 13 undocumented variables | 🟥 24 undocumented variables | |
| JSDocs coverage | Types coverage | 🟥 8 undocumented types | 🟥 10 undocumented types |
438 other audits are unchanged.
💼 Project models
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 67 | 🟡 67 | |
| Code coverage | 🟢 94 | 🟢 94 |
2 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 67 | 🟡 67 | |
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 |
10 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Types coverage | 🟥 64 undocumented types | 🟥 64 undocumented types | |
| Code coverage | Line coverage | 🟩 95 % | 🟩 94.6 % |
435 other audits are unchanged.
💼 Project create-cli
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 90 | 🟢 90 |
5 other categories are unchanged.
👍 1 group improved, 👍 1 audit improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 90 | 🟢 90 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 91.2 % | 🟩 91.2 % |
442 other audits are unchanged.
11 other projects are unchanged.
matejchalk
left a comment
There was a problem hiding this comment.
The new adjustments mechanism is very elegant. 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
matejchalk
left a comment
There was a problem hiding this comment.
(I clicked Approve automatically without thinking. 🤦)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Closes#1254
Coverage plugin binding for the setup wizard. Auto-detects Jest/Vitest, prompts for coverage options with smart defaults, and generates plugin initialization code.
For Jest/Vitest,
generateConfigreceives the wizard's virtual tree and usesmagicast(0.3.x, as the latest 0.5.x is incompatible with ourmoduleResolution: "node") to add an LCOV reporter to the test config. If the modification fails, a comment is prepended topluginInitto remind the user to configure LCOV manually.