Skip to content

refactor(models): adjust testing mocks to valid only - #184

Merged
BioPhoton merged 16 commits into
mainfrom
adjust-testing-mocks-to-valid-only
Nov 5, 2023
Merged

refactor(models): adjust testing mocks to valid only#184
BioPhoton merged 16 commits into
mainfrom
adjust-testing-mocks-to-valid-only

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Oct 30, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR includes a couple of file splittings and new types to get rid of the intermediate type hacks in models.

It also closes#173

@BioPhotonBioPhoton self-assigned this Oct 30, 2023
@BioPhotonBioPhoton added this to the 1. Internal MVP milestone Oct 30, 2023
matejchalk
matejchalk reviewed Oct 30, 2023
View reviewed changes
Comment threadpackages/models/src/lib/implementation/schemas.ts Outdated
Comment threadpackages/models/src/lib/plugin-config-groups.ts Outdated
Comment threadpackages/models/src/lib/plugin-config.ts Outdated
Comment threadtmp/.gitkeep
BioPhoton
BioPhoton commented Oct 31, 2023
View reviewed changes
Comment threadpackages/models/src/lib/implementation/schemas.ts Outdated
matejchalk
matejchalk reviewed Nov 1, 2023
View reviewed changes
Comment threadpackages/models/src/lib/implementation/schemas.ts Outdated
@BioPhoton@matejchalk
Update packages/models/src/lib/implementation/schemas.ts
397e862
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
BioPhoton merged commit 05c09ea into mainNov 5, 2023
@BioPhoton
BioPhoton deleted the adjust-testing-mocks-to-valid-only branch November 5, 2023 12:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalkmatejchalkmatejchalk approved these changes
@TlacenkaTlacenkaAwaiting requested review from Tlacenka

Assignees

@BioPhotonBioPhoton

Labels

🧹 maintenance🧩 models🔬 testingwriting tests

Projects

None yet

Milestone

1. Internal MVP

Development

Successfully merging this pull request may close these issues.

Adjust testing strategy for fixture values

2 participants

@BioPhoton@matejchalk