Uh oh!
There was an error while loading. Please reload this page.
feat(plugin-eslint): create groups from rules' metadata - #201
Merged
Conversation
matejchalk
requested review from
BioPhoton, IKatsuba, MishaSeredenkoPushBased, Tlacenka and vmasekNovember 3, 2023 16:56
BioPhoton
previously approved these changes
Nov 5, 2023
BioPhoton
left a comment
Collaborator
There was a problem hiding this comment.
Valuable change. We should add this to the eslint plugin docs.
matejchalk
commented
Nov 6, 2023
CollaboratorAuthor
Good call, just added it 😁 |
MishaSeredenkoPushBased
approved these changes
Nov 6, 2023
Tlacenka
approved these changes
Nov 6, 2023
Tlacenka
left a comment
Collaborator
There was a problem hiding this comment.
Great DX improvement!
Props for updated tests, E2E and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#200