Skip to content

feat: add transform to persist config - #229

Merged
BioPhoton merged 19 commits into
mainfrom
add-transform-to-persist-config
Nov 14, 2023
Merged

feat: add transform to persist config#229
BioPhoton merged 19 commits into
mainfrom
add-transform-to-persist-config

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Nov 10, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR is part of #92 and includes:

  • add transform to RunnerConfig
  • use transform in executePlugin
  • use transform in tests to reduce noise
  • considers a todo : @TODO consider just resting/spreading the values to reduce code

closes#228

BioPhoton
BioPhoton commented Nov 10, 2023
View reviewed changes
Comment threadpackages/models/src/lib/plugin-config-runner.ts Outdated
@BioPhotonBioPhoton mentioned this pull request Nov 10, 2023
Closed
3 tasks
@BioPhotonBioPhoton self-assigned this Nov 10, 2023
@BioPhotonBioPhoton added 🤓 UX UX improvement for CLI users 🧩 core labels Nov 11, 2023
@BioPhotonBioPhoton added this to the 1. Internal MVP milestone Nov 11, 2023
@BioPhotonBioPhoton added the 🆘 help wanted assistance is required label Nov 11, 2023
matejchalk
matejchalk requested changes Nov 13, 2023
View reviewed changes
Comment threadpackages/core/src/lib/implementation/execute-plugin.spec.ts Outdated
Comment threadpackages/core/src/lib/implementation/execute-plugin.ts Outdated
Comment threadpackages/models/src/lib/plugin-config-runner.ts Outdated
Comment threadpackages/utils/src/lib/utils.ts
Comment threadpackages/models/src/lib/plugin-config-runner.ts Outdated
Comment threadpackages/models/src/lib/plugin-config-runner.ts Outdated
Comment threadpackages/models/src/lib/plugin-config-runner.ts Outdated
@BioPhoton@matejchalk
Update packages/core/src/lib/implementation/execute-plugin.spec.ts
19a0057
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@matejchalkmatejchalk removed the 🆘 help wanted assistance is required label Nov 13, 2023
BioPhotonand others added 8 commits November 13, 2023 22:45
@BioPhoton@matejchalk
Update packages/models/src/lib/plugin-config-runner.ts
144c6b3
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton@matejchalk
Update packages/models/src/lib/plugin-config-runner.ts
08f5cbf
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor(models): rename runner prop
1ad8cab
@BioPhoton@matejchalk
Update packages/models/src/lib/plugin-config-runner.ts
a5e5bc5
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor: make transform plugin output async
4a66547
@BioPhoton@matejchalk
Update packages/core/src/lib/implementation/execute-plugin.ts
0f96d91
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor: fix typing
315d4bc
@BioPhoton
refactor: merge main
2403ba9
matejchalk
matejchalk previously approved these changes Nov 14, 2023
View reviewed changes
Comment threadpackages/core/src/lib/implementation/execute-plugin.ts Outdated
@BioPhoton
BioPhoton merged commit ce4d975 into mainNov 14, 2023
@BioPhoton
BioPhoton deleted the add-transform-to-persist-config branch November 14, 2023 11:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalkmatejchalkmatejchalk approved these changes

Assignees

@BioPhotonBioPhoton

Labels

🧩 core🤓 UXUX improvement for CLI users

Projects

None yet

Milestone

1. Internal MVP

Development

Successfully merging this pull request may close these issues.

Adoption of RunnerConfig with a optional transform function.

2 participants

@BioPhoton@matejchalk